trunk: the allowed list keeps the four media defaults, so a remainder is 13-4094 #1946

Merged
jaylouisw merged 1 commit from rev/1118-0501 into main 2026-11-18 07:12:09 +00:00
Owner

Carried over from the 05:01 reverse-engineering run, whose push never reached the server: the commit sat in the worktree while Forgejo answered Internal Server Connection Error. It is pushed now, unmodified.

switchport trunk allowed vlan remove <list> on a trunk that still allows the default all used to print 1-4,7,11,13-1001,1006-4094 - two runs around VLANs 1002-1005, which no box prints. A trunk's allowed list is 802.1Q tags over 1-4094 and the four media defaults are in it (Cisco's c3550 transcript of remove 5-10,12 + add 7 prints 1-4,7,11,13-4094), so they cannot be removed from it; the parse rule that keeps a port out of VLAN 1002 was being applied to a trunk's tag list.

Detail and sources: research/trunk-allowed-reserved-vlans.md.

Tests: trunk-allowed-reserved-vlans 29 passed, trunk-allowed-remove-from-all 45 passed; the full suite on this tree ran 334 suites / 11,588 assertions / 0 failed.

Carried over from the 05:01 reverse-engineering run, whose push never reached the server: the commit sat in the worktree while Forgejo answered `Internal Server Connection Error`. It is pushed now, unmodified. `switchport trunk allowed vlan remove <list>` on a trunk that still allows the default `all` used to print `1-4,7,11,13-1001,1006-4094` - two runs around VLANs 1002-1005, which no box prints. A trunk's allowed list is 802.1Q tags over 1-4094 and the four media defaults are in it (Cisco's c3550 transcript of `remove 5-10,12` + `add 7` prints `1-4,7,11,13-4094`), so they cannot be removed from it; the parse rule that keeps a *port* out of VLAN 1002 was being applied to a *trunk's* tag list. Detail and sources: `research/trunk-allowed-reserved-vlans.md`. Tests: `trunk-allowed-reserved-vlans` 29 passed, `trunk-allowed-remove-from-all` 45 passed; the full suite on this tree ran 334 suites / 11,588 assertions / 0 failed.
trunk: the allowed list keeps the four media defaults, so a remainder is 13-4094
Some checks failed
CI / Classify the change (pull_request) Successful in 6s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 4s
CI / Server smoke test (pull_request) Successful in 5s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Test (Node 22) (pull_request) Successful in 57s
CI / Arm auto-merge (pull_request) Successful in 2s
721fa5e16d
`switchport trunk allowed vlan remove 5-10,12` on a default trunk printed
`1-4,11,13-1001,1006-4094`, and the shared vlan-list parser refused 1002-1005 in
every list. A trunk's allowed list is the one list where they belong: the
device's default list is 1-4094, a switch documents that the four media defaults
cannot be removed from a trunk, and Cisco's c3550 transcript of that exact
command answers `1-4,7,11,13-4094` (research/trunk-allowed-reserved-vlans.md).

The rule that a port cannot sit in VLAN 1002 stays where it belongs: access,
native and voice VLANs still refuse the block, and parseVlanList() is strict by
default so no caller inherits the allowed-list rule by accident.
Author
Owner

Surgery loop: one leg red, not reproducible - needs a re-run, not a rebase.

Head 721fa5e1: Test (Node 18) success, Test (Node 22) success, Test (Node 20) failure. Everything else green, Arm auto-merge armed.

Classified as not superseded: merging origin/main (5f1ce466) into this branch is clean - auto-merged engine/cli.js, no CONFLICT (add/add), nothing already on main.

Local reproduction attempt (Node v24.11.0), head merged into main:

node scripts/run-tests.js --filter=trunk   ->  4 suites,  163 assertions, 0 failed
node scripts/run-tests.js --filter=vlan    -> 16 suites,  487 assertions, 0 failed

So the trunk/vlan surface this PR touches is green here, and green on Node 18 and 22 in CI. With 18 and 22 both passing, a genuine Node-20-only code defect is unlikely - it looks like a flake or a Node-20 leg that hit the host while it was still recovering (the API was answering DB queries in ~70 s at 06:23 and the test legs on #1942 sat pending for 35+ minutes).

What I need: a re-run of the Node 20 leg (or a push that re-triggers it). I am not merging on a red head-SHA status - that is the standing rule - and I am not touching engine/ or test/ to chase a failure I cannot see. I also cannot fetch the job log: this Forgejo build has no /actions/runs or /actions/jobs/*/logs API, so the failure text is only visible in the web UI.

If the re-run goes red again on Node 20 only, that is a real Node-20 issue and I will escalate it with the failing suite name once someone pastes the log.

**Surgery loop: one leg red, not reproducible - needs a re-run, not a rebase.** Head `721fa5e1`: `Test (Node 18)` **success**, `Test (Node 22)` **success**, `Test (Node 20)` **failure**. Everything else green, `Arm auto-merge` armed. Classified as **not superseded**: merging `origin/main` (`5f1ce466`) into this branch is clean - auto-merged `engine/cli.js`, no `CONFLICT (add/add)`, nothing already on main. **Local reproduction attempt (Node v24.11.0), head merged into main:** ``` node scripts/run-tests.js --filter=trunk -> 4 suites, 163 assertions, 0 failed node scripts/run-tests.js --filter=vlan -> 16 suites, 487 assertions, 0 failed ``` So the trunk/vlan surface this PR touches is green here, and green on Node 18 and 22 in CI. With 18 and 22 both passing, a genuine Node-20-only code defect is unlikely - it looks like a flake or a Node-20 leg that hit the host while it was still recovering (the API was answering DB queries in ~70 s at 06:23 and the test legs on #1942 sat pending for 35+ minutes). **What I need:** a re-run of the Node 20 leg (or a push that re-triggers it). I am not merging on a red head-SHA status - that is the standing rule - and I am not touching `engine/` or `test/` to chase a failure I cannot see. I also cannot fetch the job log: this Forgejo build has no `/actions/runs` or `/actions/jobs/*/logs` API, so the failure text is only visible in the web UI. If the re-run goes red again on Node 20 only, that is a real Node-20 issue and I will escalate it with the failing suite name once someone pastes the log.
jaylouisw force-pushed rev/1118-0501 from 721fa5e16d
Some checks failed
CI / Classify the change (pull_request) Successful in 6s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 4s
CI / Server smoke test (pull_request) Successful in 5s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Test (Node 22) (pull_request) Successful in 57s
CI / Arm auto-merge (pull_request) Successful in 2s
to 377ddbc688
All checks were successful
CI / Classify the change (pull_request) Successful in 5s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Successful in 48s
CI / Test (Node 18) (pull_request) Successful in 55s
CI / Test (Node 22) (pull_request) Successful in 51s
CI / Arm auto-merge (pull_request) Successful in 18s
2026-11-18 07:09:54 +00:00
Compare
jaylouisw force-pushed rev/1118-0501 from 377ddbc688
All checks were successful
CI / Classify the change (pull_request) Successful in 5s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Successful in 48s
CI / Test (Node 18) (pull_request) Successful in 55s
CI / Test (Node 22) (pull_request) Successful in 51s
CI / Arm auto-merge (pull_request) Successful in 18s
to 72b4e6dc1f
All checks were successful
CI / Classify the change (pull_request) Successful in 6s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Server smoke test (pull_request) Successful in 6s
CI / Docker build (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Successful in 51s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Test (Node 22) (pull_request) Successful in 55s
CI / Arm auto-merge (pull_request) Successful in 9s
2026-11-18 07:10:09 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1946
No description provided.