traceroute: a name is resolved first, and the target line carries both names (#1484) #1865
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1865
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "rev/1117-1530"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
helphas claimedtraceroute|tracert <address|name>since the command landed, and_traceroute()put its one argument throughnet.isIp()- sotraceroute srv.labwas refused as an invalid target whileping srv.lab, two lines above it in the same ticket, resolved through the lab DNS.What a box prints (research/traceroute-name-target.md)
The order matters and is not obvious: the lookup precedes the abort line (as
ping's does), and the target line carries both names - typed name first, resolved address in parentheses. The target line has vendor-documentation backing (Catalyst 9600 guide,Tracing the route to ABA.NYC.mil (26.0.0.73)); the position of the lookup line rests on two Cisco Community pastes, which the note records as a weaker class of evidence.What changed
_traceroute()classifies its argument: IPv4 literal (isIpv4Literal(), ping's octet-range check lifted to module scope), digits-and-dots typo (ping's parenthetical), IPv6 literal (refused as an IPv4-only walk, not sent to the resolver), or a name.Simulator.resolveName(); the lookup line is printed with[OK]only on success; the target line becomesTracing the route to <name> (<address>); the walk itself is unchanged._translationLine()and_resolveFailureLines()extracted fromping, shared by both commands - ping's output is byte-identical and its tests pass unchanged.docs/CLI.md: the table row now reads<address|name>, a new "Tracing a name" section carries the transcripts, and the paragraph claiming the index row was not real now says onlymax <n>is not.Tests
test/traceroute-name.test.js, 23 assertions, including: every hop line, figure and verdict is identical to the trace the address form walks.test/icmp-errors-traceroute.test.jsupdated:traceroute not-an-ipis now a name, refused by the resolver; a digits-and-dots target is still refused as an address.faceplate-clipping; it passes standalone and the final run is green).Not settled (recorded in the note)
The blank line after the lookup; the real box wording for an unresolvable name (this console prints its own resolver verdict); per-hop PTR names (the model holds no PTR records); and
max <n>, still indexed and still swallowed.dd120f85d033e3ec648f