plan: two catalogue audits ask one question, and the ungated one is 33 devices wrong #1839
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1839
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "plan/1117-1210"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forward plan only, no code:
docs/plans/catalogue-audit-agreement.md.Measured on
1855814a:test/hardware-invariants.test.jsgates "advertises optics without an optical cage" and asserts 0 (test/known-issues.json->opticsWithoutCage: []).scripts/audit-devices.jsasks the same question with a hardcoded 5-entryOPTICAL_CAGES(:16) and no optional-module clause, and answers 33 � 28 PON (sc-apc/sc-upc), 3 Fibre Channel (fc-sfp*/fc-qsfp28), 2 optional-SFP prose.engine/media.js:339already classifies all of those cages (family: optical/fibre-channel); neither audit reads it.audit-devices� no npm script, no workflow � and itprocess.exit()s at import (:81), so no test can ask it anything.Six S-sized steps: make the audit importable, pin the disagreement as a failing test, one
isOpticalCage()predicate inengine/media.js(33 -> 2), strip the optional clause (2 -> 0), decide whether the audit runs innpm testor is deleted (delete = needs Jays approval), and let both audits verdict lines name what they gated versus what they merely reported.Closes no open issue: the queue is seven device requests. Deliberately leaves out the 2,968 undeclared template ports (#71), the OTN media family (
docs/plans/stated-configurations.mdstep 6), and stale counts in a test header.