docs(CLI): the NAT refusal block quotes two lines the console never says #1832

Merged
jaylouisw merged 1 commit from docs/1117-1115 into main 2026-11-17 11:26:49 +00:00
Owner

docs/CLI.md lists NAT's specific refusals, and three of those lines were not what engine/cli.js returns.

  • The backwards-pool refusal is % Pool "WAN" ends before it starts (...): engine/cli.js:4177 has returned that since the console learned NAT (#1367), never % NAT pool ....
  • The ACL-number refusal ends ... or list any (engine/cli.js:4231-4232); the page cut that clause at the line wrap.
  • The PAT refusal is returned as one line, not two.

Every line in the block is now copied from a run on a generic router (pool TWO with two addresses, an interface with no address, pool WAN running backwards), so a reader comparing their console to the page reads the same sentence.

Guards after the edit: syntax-check 384 files, docs-cli-transcript 4/4, docs-show-commands 7/7, help-completeness 8/8, no-form-help-key 81/81 - counts unchanged before and after.

Docs-only; no engine change.

`docs/CLI.md` lists NAT's specific refusals, and three of those lines were not what `engine/cli.js` returns. - The backwards-pool refusal is `% Pool "WAN" ends before it starts (...)`: `engine/cli.js:4177` has returned that since the console learned NAT (#1367), never `% NAT pool ...`. - The ACL-number refusal ends `... or list any` (`engine/cli.js:4231-4232`); the page cut that clause at the line wrap. - The PAT refusal is returned as one line, not two. Every line in the block is now copied from a run on a generic router (pool TWO with two addresses, an interface with no address, pool WAN running backwards), so a reader comparing their console to the page reads the same sentence. Guards after the edit: syntax-check 384 files, docs-cli-transcript 4/4, docs-show-commands 7/7, help-completeness 8/8, no-form-help-key 81/81 - counts unchanged before and after. Docs-only; no engine change.
docs(CLI): the NAT refusal block quotes two lines the console never says
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Classify the change (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Arm auto-merge (pull_request) Successful in 8s
1cdd5c060c
The block listing NAT's specific refusals had drifted from the messages in
engine/cli.js, and both wrong lines were there from the day the feature
landed (#1367):

* the backwards-pool refusal is `% Pool "WAN" ends before it starts ...`
  (cli.js:4177), not `% NAT pool "WAN" ...`;
* the ACL-number refusal ends "... or `list any`" (cli.js:4231-4232), a
  clause the page dropped at the line wrap;
* the PAT refusal is one line, not two: the console returns it whole.

Each line is now copied verbatim from a run, so an operator comparing their
console to the page reads the same sentence.
jaylouisw force-pushed docs/1117-1115 from 1cdd5c060c
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Classify the change (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Arm auto-merge (pull_request) Successful in 8s
to 87e8f9594b
All checks were successful
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 55s
CI / Test (Node 22) (pull_request) Successful in 1m1s
CI / Test (Node 18) (pull_request) Successful in 1m4s
CI / Arm auto-merge (pull_request) Successful in 22s
2026-11-17 11:24:18 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1832
No description provided.