docs(LINK-STATE): the link-state suite holds 69 assertions, not 67 #1754

Merged
jaylouisw merged 1 commit from docs/1117-0015 into main 2026-11-17 00:30:21 +00:00
Owner

docs/LINK-STATE.md said test/link-state.test.js holds 67 assertions. Running the file the page names prints 69 ticks and 69 passed, 0 failed, so the number understated the suite by two.

Evidence

  • node test/link-state.test.js -> 69 passed, 0 failed (one tick per assertion; counted 69).
  • The 67 was written with the feature in #1058; #1331 (The clock moves when the board changes) reworked the link-state and CLI assertions afterwards and the count was not revisited.

Change

One line: 67 -> 69. The enumeration of what the file covers is unchanged and still accurate (a down link carries nothing and names where the frame died, setLinkState refusals, the tree healing, the re-based schedule, MAC flush, the DHCP segment walk refusing a cut cable, save/load, the CLI surface).

Guards

  • scripts/syntax-check.js: 367 files, all OK (before and after)
  • test/docs-show-commands.test.js: 7 passed / 0 failed
  • test/help-completeness.test.js: 8 passed / 0 failed
  • test/no-form-help-key.test.js: 81 passed / 0 failed
  • test/doc-catalog-counts.test.js: 43 checks passed
  • test/canonical-urls.test.js: 52 passed / 0 failed
`docs/LINK-STATE.md` said `test/link-state.test.js` holds **67 assertions**. Running the file the page names prints 69 ticks and `69 passed, 0 failed`, so the number understated the suite by two. **Evidence** - `node test/link-state.test.js` -> `69 passed, 0 failed` (one tick per assertion; counted 69). - The 67 was written with the feature in #1058; #1331 (`The clock moves when the board changes`) reworked the link-state and CLI assertions afterwards and the count was not revisited. **Change** One line: 67 -> 69. The enumeration of what the file covers is unchanged and still accurate (a down link carries nothing and names where the frame died, `setLinkState` refusals, the tree healing, the re-based schedule, MAC flush, the DHCP segment walk refusing a cut cable, save/load, the CLI surface). **Guards** - `scripts/syntax-check.js`: 367 files, all OK (before and after) - `test/docs-show-commands.test.js`: 7 passed / 0 failed - `test/help-completeness.test.js`: 8 passed / 0 failed - `test/no-form-help-key.test.js`: 81 passed / 0 failed - `test/doc-catalog-counts.test.js`: 43 checks passed - `test/canonical-urls.test.js`: 52 passed / 0 failed
docs(LINK-STATE): the link-state suite holds 69 assertions, not 67
All checks were successful
CI / Classify the change (pull_request) Successful in 11s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 22s
CI / Server smoke test (pull_request) Successful in 17s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Successful in 57s
CI / Test (Node 18) (pull_request) Successful in 1m3s
CI / Test (Node 22) (pull_request) Successful in 1m2s
CI / Arm auto-merge (pull_request) Successful in 5s
7f753a12c0
The number was written with the feature in #1058 and the suite has grown
since: `node test/link-state.test.js` reports 69 passed, 0 failed, and the
file prints one tick per assertion, so 69 is the count a reader would get by
running the line the page names. The enumeration beside it is unchanged and
still describes what the file covers.
jaylouisw force-pushed docs/1117-0015 from 7f753a12c0
All checks were successful
CI / Classify the change (pull_request) Successful in 11s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 22s
CI / Server smoke test (pull_request) Successful in 17s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Successful in 57s
CI / Test (Node 18) (pull_request) Successful in 1m3s
CI / Test (Node 22) (pull_request) Successful in 1m2s
CI / Arm auto-merge (pull_request) Successful in 5s
to 839fe7a3d3
All checks were successful
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 19s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 56s
CI / Test (Node 18) (pull_request) Successful in 1m2s
CI / Test (Node 22) (pull_request) Successful in 1m0s
CI / Arm auto-merge (pull_request) Successful in 15s
2026-11-17 00:27:10 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1754
No description provided.