cli: converge's Device column is as wide as the longest name in the answer (#1732) #1733
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1733
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-2105"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1732.
pad()right-pads and never truncates, so the fixed 23-character Device column did not widen for a longer name - the name ran into the instant. Default names arelabel + '-' + last four characters of the id, and 1475 of the 2329 catalogue specs exceed 22 characters that way, so an untouched ISR 4331 lab printed:which reads as the instant
r116000 mson a device namedrouter-r1. The heading was hand-typed on top of that and putBasisat column 41 over data at 43.Change: widths come from the data, with the table's existing minimums (10/23/10) as floors, so a lab of short names prints byte-for-byte what it printed before and the
docs/CONVERGENCE.md/docs/LINK-STATE.mdsamples stay true; header and rows are built from the one set of widths so they cannot drift apart (the ruleshow lldp neighborsfollows since #1265). Both doc samples re-aligned, and CONVERGENCE.md gains a sentence on the widening.Test:
test/converge-table-geometry.test.js- 17 assertions, 6 failing on main (default 25-character name, a 41-character name, short names unchanged, and pending/converged sharing one geometry).Gates: syntax-check 362 files OK; the eleven converge/link/clock suites pass;
npm test291 suites / 10,353 assertions / 0 failed (442.8 s).c21fe11e74c813fef5d8