docs(CI): a data-only diff still runs all three Node legs #1704

Merged
jaylouisw merged 1 commit from docs/1116-1815 into main 2026-11-16 18:19:39 +00:00
Owner

docs/CI.md said a data-only pull request runs the test job on Node 20 only, so npm test was checked "once instead of three times".

The workflow says otherwise, twice:

  • the test job is guarded only by needs.changes.outputs.live != 'false', and its strategy is matrix: node: [18, 20, 22] for every open pull request � there is no data_only term in it;
  • data_only is read in exactly two places: the if: of the smoke job (line 366) and of the docker job (line 394).

The workflow comment above the matrix records why the reduction was removed: an if: reading matrix.node is evaluated before the matrix exists, so every leg died ~2 s in (runs 1398, 1401, 1402 � three red Xs per pull request), and a matrix built from an expression collapses to a single unnamed leg that runs the suite once and reports coverage it never had. "So: three versions, always."

Changed (docs only): the table now reads Test (Node 18/20/22) ? three legs for both kinds of diff, with a line saying only the last two columns differ; the paragraph explains what the data-only saving actually buys (two ten-minute jobs, smoke and docker, against ~60 s for the suite); and the "five checks, all required before a merge" sentence gains the qualification the page was already contradicting three screens later.

Guards, before = after: syntax-check 356 files OK, control-bytes clean, doc-catalog-counts 43/43, doc-citations 11/11, docs-show-commands 7/7 (51 forms / 102 commands / 60 refusals), help-completeness 8/8, no-form-help-key 81/81.

`docs/CI.md` said a data-only pull request runs the test job on **Node 20 only**, so `npm test` was checked "once instead of three times". **The workflow says otherwise, twice:** - the `test` job is guarded only by `needs.changes.outputs.live != 'false'`, and its strategy is `matrix: node: [18, 20, 22]` for every open pull request � there is no `data_only` term in it; - `data_only` is read in exactly two places: the `if:` of the `smoke` job (line 366) and of the `docker` job (line 394). The workflow comment above the matrix records why the reduction was removed: an `if:` reading `matrix.node` is evaluated before the matrix exists, so every leg died ~2 s in (runs 1398, 1401, 1402 � three red Xs per pull request), and a matrix built from an expression collapses to a single unnamed leg that runs the suite once and reports coverage it never had. "So: three versions, always." **Changed** (docs only): the table now reads `Test (Node 18/20/22)` ? *three legs* for both kinds of diff, with a line saying only the last two columns differ; the paragraph explains what the data-only saving actually buys (two ten-minute jobs, `smoke` and `docker`, against ~60 s for the suite); and the "five checks, all required before a merge" sentence gains the qualification the page was already contradicting three screens later. **Guards, before = after:** syntax-check 356 files OK, control-bytes clean, doc-catalog-counts 43/43, doc-citations 11/11, docs-show-commands 7/7 (51 forms / 102 commands / 60 refusals), help-completeness 8/8, no-form-help-key 81/81.
docs(CI): a data-only diff still runs all three Node legs (#CI.md)
All checks were successful
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Test (Node 18) (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Has been skipped
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
229e3b9244
The gating table claimed a data-only pull request runs the test job on Node 20
only, and that `npm test` therefore runs "once instead of three times". The
workflow says otherwise twice over: `test` is guarded only by
`needs.changes.outputs.live != 'false'` and its matrix is `node: [18, 20, 22]`
for every open pull request, and `data_only` is read in exactly two places -
the `smoke` and `docker` jobs' `if:` (lines 366 and 394). The workflow's own
comment records why the reduction was removed: an `if:` reading `matrix.node`
is evaluated before the matrix exists, so every leg died ~2 s in (runs 1398,
1401, 1402), and a matrix built from an expression collapses to one unnamed leg
that reports coverage it never had.

The table now says what the workflow does - three legs either way, only
`smoke` and `docker` skip a JSON-only diff - and the prose says what that
saving is actually worth (two ten-minute jobs, against ~60 s for the suite).
The 'five checks, all required' sentence gains the one qualification the page
was already contradicting three screens later.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 18:19:24 +00:00
jaylouisw force-pushed docs/1116-1815 from 229e3b9244
All checks were successful
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Test (Node 18) (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Has been skipped
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
to 18f3511f30
All checks were successful
CI / Classify the change (pull_request) Successful in 13s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Test (Node 18) (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Has been skipped
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
2026-11-16 18:19:28 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1704
No description provided.