plan: the request queue's duplicate test cannot see a slug-named model (#795) #1703
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1703
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "plan/1116-1810"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forward plan only, no code.
docs/plans/request-queue-duplicates.md.Two scripts answer "is this request already modelled?" and they disagree.
scripts/request-queue.js:68,109comparesvendor|modelverbatim;scripts/sweep-device-requests.js:110normalises (entities, dashes, punctuation) and has nine guard-documented cases behind it intest/sweep-requests.test.js.Measured on
9438e075against the live tracker (20 opendevice-requestissues, 2,257 catalogue specs of which 1,682 are slugs):devices/huawei/netengine-8000-m4.jsonSo the queue offers hardware that is already in the catalogue as the next device to write. The predicate also has no test and no seam (
:193parseIssue: null), and neither script runs anywhere —closed-audit.ymlis the only workflow that runs an issue script.Six ordered steps, each one PR: (1) extract one matcher module and re-export from the sweeper so its suite is untouched, (2) the queue asks it, with #795 as the regression fixture, (3) negatives that protect the guards (
UDW-PROvsUDW,NC8400-4THvsnc8200-4td), (4) the sweeper takes its API base from the probecheck-closed-issues.js:109-140already uses, (5) a report-only workflow on merge in theclosed-audit.ymlshape, (6) the close pass — tracker action, needs Jay.Left out deliberately: automatic closing, the 19 device specs themselves, a second fuzzy tier, and #1507 (host work).