catalogue: salvage 28 device models stranded on seven PR-less branches #1702
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1702
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "surgery/salvage-device-batch"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Salvage of the work stranded on seven branches that have no PR in 500 closed records.
What was stranded
devices/catalogue-batch99ec4e70(9 Nov)devices/four-nvr-models14ddbfe4devices/nvr-and-taps1ccef65bdevices/pon-splitters790ae572devices/powerline-mocae74dc3c6devices/firewalls-enterprise682c1272feat/device-ubiquiti-wave-fiber-onu9d6ddbe9They add 28 device JSONs main has never seen - Amcrest/Hanwha/Uniview/Vivotek/Dahua NVRs, Checkpoint/SonicWall/WatchGuard firewalls, AVM + ScreenBeam powerline, Prysmian + CommScope splitters, ProfiTap taps, Fujitsu/Gigabyte servers, Moxa, Perle, FS, Trendnet, Comtrend, TP-Link. Every file here is byte-identical to its blob on those branches (verified per file with
git hash-objectagainst each branch), so this PR is the union of the seven, with no rewrites.What is deliberately not carried
engine/device.js,engine/simulator.js,engine/topology.jsanddevices/registry.jsfromdevices/catalogue-batch: engine work belongs to the sibling loops, and the current engine loads all 28 specs unchanged.devices/ubiquiti/wave-fiber-onu.jsonfrom the feat branch: a duplicate ofwavefiber-onu.jsonalready on main (catalogue-hygiene refuses two specs for one box).Verification
npm test: 285 suites, 10,234 assertions, 0 failed (readme/docs counts regenerated first withnpm run regen:registry-doc).node scripts/audit-port-types.jsclean,node scripts/check-control-bytes.jsclean.Opened by the surgery loop; close it if these models should stay unsalvaged.
Seven remote branches from 8-9 Nov carry device specs that main has never seen and that no pull request ever referenced: devices/catalogue-batch (28 JSONs), devices/{four-nvr-models,nvr-and-taps,pon-splitters, powerline-moca,firewalls-enterprise} and feat/device-ubiquiti-wave-fiber-onu. Every file below is byte-identical to its blob on those branches, so this commit adds the union and loses nothing. The branches also touched engine/{device,simulator,topology}.js and devices/registry.js; none of that is carried here - the current engine loads all 28 specs unchanged, and engine/ belongs to the sibling loops. Dropped: feat/device-ubiquiti-wave-fiber-onu's devices/ubiquiti/wave-fiber-onu.json, a duplicate of the wavefiber-onu.json already on main (catalogue-hygiene flags it). docs/ and README counts regenerated with npm run regen:registry-doc (2,252 -> 2,280 models, 252 -> 258 vendors, 897 -> 921 port shapes). npm test: 285 suites, 10,234 assertions, 0 failed.This branch conflicts with
main, so it was not rebased:A conflict is a decision about behaviour rather than a mechanical fix, so this is left for a human. Rebasing by hand and force-pushing will let the automation pick it up again.
10d25660614f17172c38