cli: a ? at the end of a no line removes nothing and names the syntax #1699
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1699
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-1706"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1694
noreads the tokens it needs and ignores the rest, so a?typed where the operator expected help was one more token to ignore and the line acted:The key is refused at the top of config, interface and DHCP pool mode - before any
nobranch acts, which is the only place it can be caught, because the damage is done by the tokens before the key - and the answer is written in the words of the branch it stopped:What is not changed, and is pinned: a
?inside a longer word is still part of the value (no vlan 42 name lab?1runs), a bareno ?is answered as the short line it is (and points at the index), and every realnoline still works.Tests: new test/no-form-help-key.test.js (81 assertions) covering the three forms from the issue plus the sweep over the other heads that ignore trailing tokens -
no spanning-tree,no access-list,no ip route,no ip nat pool,no ip address,no shutdown, and in DHCP pool modeno networkandno pool(which removed the whole pool).Gates: node scripts/syntax-check.js (355 files, all OK); full npm test - 284 suites, 10216 assertions passed, 0 failed.
?at the end of anoline removes nothing and names the syntax (#1694)ebe19947d53bcfac72d7?key at the end of anoline is refused with the syntax it stopped #1710