cli: the help key is not a description or a pool name (#1691) #1693
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1693
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-1636"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1691.
Two free-text positions still stored the help key as the text:
Both now refuse before anything is written, through the
_helpKeyRefusalhelper #1685 added, whichgained the noun so a description reads "not a description" instead of "not a name":
Only the whole value is the key:
description edge?1and a pool namedpool?1still work.Tests:
test/help-key-is-not-a-value.test.jsgained sections 5 and 6 (17 assertions); 12 of themfailed before the fix, 40 pass after.
node scripts/syntax-check.js— 354 files OK.npm test— 283 suites, 10125 assertions, 0 failed.Not in this PR: the
noforms read the tokens they need and ignore the rest, sono hostname ?,no vlan 42 name ?andno description ?clear/delete instead of asking. Filed separately; differentmechanism, different fix.
e1672ab54db54890f2bb