ci: stop pre-cloning an action that never runs - 22-36 s off every test leg #1688
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1688
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1116-1621"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was slow
Every leg of
Test (Node 18/20/22)paid 22-36 s before its first step, to pre-clone an action that never executes.Baseline (run 3887, main
268ddd58, 16:20-16:22, all green):The gap is the runner fetching
actions/setup-node@v4for the job's `uses:` list before any step runs:Same shape in earlier runs: 3877 (PR #1686) Node 22 = 32 s, 3884 = 36 s. In none of them did setup-node run - Node 20 excludes it by
if:, and the 18/22 legs had already installed the pinned tarball. It was not an independent fallback either:setup-nodedownloads fromnodejs.org/dist, the same host and tarball the step above it fetches.Change
Removed the
actions/setup-node@v4fallback step. The hedge it provided is kept as a second attempt inside the download step: curl's own retries, then one more attempt after 5 s with a clean destination each time (so a truncated tarball cannot be bolted onto).Verified in the real runner image (
node:20-bookworm):installed /usr/local/bin/node: v18.20.8 / npm 10.8.2The runtime is the version this leg is named forstill fails the leg loudlyCoverage unchanged
[18, 20, 22],fail-fast: false, all three legs still runnpm test+scripts/syntax-check.jsand all four static checks and both example steps.