cli: show ? lists the views instead of calling the key an invalid command #1679
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1679
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-1435"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1673
At the view-word position — the second of the two places this console keeps a complete table (the note over
EXEC_WORDS) —?was answered as a typo, while one word deeper the same question had always been answered in full:What changed (
engine/cli.js)show ?(andsh ?) answers fromSHOW_VIEW_WORDS, the table the dispatcher resolvessh veragainst, so the list cannot advertise a view thatshowthen refuses.show, so the list is pasteable the way the views it lists are:macandpowerare printed with the word they need (address-table,inline), because bare they are refused.ver = version,interface = interfaces,run = running-config,port-channel = etherchannel,access-list = access-lists.ipandipv6take a view of their own and get their own line.show ipv6 ?now answers with its one view,nd, where it was the same invalid-command report.interface ?/speed ?are still left alone — there is no complete table there, so the console does not guess.Tests —
test/help-key-works-in-every-prompt.test.jsgained a tenth test that pins every printed row, every alias, bothipdoors, and types each printed form back. Reproduce first, then fix: the assertion failed with% Invalid show command: ?before the change.Gates —
npm test281 suites / 10,064 assertions / 0 failed; syntax 352 files OK; control bytes clean; canonical URLs 2,835 files; node surface clean;missing-devices examplesCI gate passed;check-doc-citations0 suspects (three citations shifted by this diff refreshed to the lines the code is on;docs/CLI.mddocuments the new answer).show ?lists the views instead of calling the key an invalid command (#1673)This branch conflicts with
main, so it was not rebased:A conflict is a decision about behaviour rather than a mechanical fix, so this is left for a human. Rebasing by hand and force-pushing will let the automation pick it up again.
This branch conflicts with
main, so it was not rebased:A conflict is a decision about behaviour rather than a mechanical fix, so this is left for a human. Rebasing by hand and force-pushing will let the automation pick it up again.