docs(ARCHITECTURE): show vlan brief is not a view of a trunk's allowed list, and the test is 45 checks #1659

Merged
jaylouisw merged 1 commit from docs/1116-1215 into main 2026-11-16 12:22:38 +00:00
Owner

docs/ARCHITECTURE.mds trunk-allowed section claimed the engine state, show running-config, show interfaces <port> and show vlan brief are compared "against each other" after every edit, and cited 42 checks for test/trunk-allowed-add-remove.test.js.

Both are untrue since #1638. Measured on origin/main:

  • setting switchport trunk allowed vlan 10,20,30 on a trunk leaves show vlan brief with no rows for 10/20/30 and the trunk port in no row at all (probe against engine/cli.js), and the test now asserts exactly that absence;
  • node test/trunk-allowed-add-remove.test.js reports 45 passed, 0 failed, not 42.

The paragraph now names the three views that do agree and says why show vlan brief is deliberately not one of them. Docs-only; no code touched.

docs/ARCHITECTURE.mds trunk-allowed section claimed the engine state, `show running-config`, `show interfaces <port>` and `show vlan brief` are compared "against each other" after every edit, and cited 42 checks for `test/trunk-allowed-add-remove.test.js`. Both are untrue since #1638. Measured on `origin/main`: - setting `switchport trunk allowed vlan 10,20,30` on a trunk leaves `show vlan brief` with no rows for 10/20/30 and the trunk port in no row at all (probe against engine/cli.js), and the test now asserts exactly that absence; - `node test/trunk-allowed-add-remove.test.js` reports `45 passed, 0 failed`, not 42. The paragraph now names the three views that do agree and says why `show vlan brief` is deliberately not one of them. Docs-only; no code touched.
docs(ARCHITECTURE): show vlan brief is not a view of a trunk allowed list
All checks were successful
CI / Classify the change (pull_request) Successful in 13s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 1m32s
CI / Test (Node 20) (pull_request) Successful in 1m32s
CI / Test (Node 22) (pull_request) Successful in 1m40s
e216b939a8
#1638 made show vlan brief a view of the VLAN database: a VLAN a trunk
allows but nobody created gets no row, and a trunk appears in no row even
when the VLAN exists. ARCHITECTURE.md still said show vlan brief was
compared "against each other" with the trunk list, and quoted 42 checks;
the test now asserts the absence and reports 45.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 12:22:30 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1659
No description provided.