LAG: a MAC learned on the dead member is re-hashed onto a live one (#1515) #1605
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1605
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-0435"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1515
What was wrong
A flood nominates every member of a bundle, so a two-member LAG survived losing a cable while every frame was a flood. A known unicast nominates exactly the port the MAC table names, and that list was handed to the hash as-is: if the table named the member whose cable had just been pulled, the pool had one candidate - one dead port - and the frame went there and was dropped
link downwhile the live member sat idle.Measured before the fix (a MAC learned on Fa0/3, cable pulled):
So the bundle carried traffic until the first known-unicast frame, then stopped - the case bundles exist for.
What changed
_egressRefusal(), read by both the nominated-port filter and the pool, so the two cannot drift apart.After:
replies true,true,true,true, every frame leaves by Fa0/2, and the exchange is never billed to the pulled cable.Tests
New section in
test/lag-member-down.test.js: A MAC the table learned on the member that then died moves to a live member (+4 assertions, 34 in the file). The first two assertions fail on the old code and pass on the new; the rest cover the flood path and the no-live-member accounting.Gates:
node scripts/syntax-check.js333 files OK; fullnpm test263 suites / 9552 assertions / 0 failed.No new feature - the bundle's own rule, applied to the path that was not reading it.
993b9e1cf5c1f53e597e