README: the catalogue holds 2,109 models across 252 vendors, not 1,544 across 245 #1584

Merged
jaylouisw merged 1 commit from docs/1116-0217 into main 2026-11-16 02:37:10 +00:00
Owner

The Vendors row in README.md stated 1,544 models across 245 vendors. Loading devices/ gives 2,109 models across 252 vendors in 25 categories � the same numbers test/doc-catalog-counts.test.js asserts in docs/DEVICE_REGISTRY.md, and the same sentence scripts/regen-registry-doc.js keeps true there.

README is outside that generator and outside that test, so the sentence froze at its last hand edit (#1050) while the catalogue grew. Nothing here is a code change: the doc was the claim, the directory was the truth, and the claim lost.

The category list in the same cell named TV/set-top, which no device carries, and left out wireless (219 models, third-largest). It now names wireless in that slot, so the 25 names are the 25 categories the catalogue actually has.

Guards after the edit: syntax-check 333 files OK; docs-show-commands 7/7; help-completeness 8/8; doc-catalog-counts 24/24; canonical-urls 52/52; control-bytes clean; doc citations 350 with the same 5 tolerated suspects as before.

Not done here (out of a docs-only PR): README is still unguarded, so this will drift again unless regen-registry-doc.js learns to rewrite it or a test reads it.

The `Vendors` row in README.md stated **1,544 models across 245 vendors**. Loading `devices/` gives **2,109 models across 252 vendors** in 25 categories � the same numbers `test/doc-catalog-counts.test.js` asserts in `docs/DEVICE_REGISTRY.md`, and the same sentence `scripts/regen-registry-doc.js` keeps true there. README is outside that generator and outside that test, so the sentence froze at its last hand edit (#1050) while the catalogue grew. Nothing here is a code change: the doc was the claim, the directory was the truth, and the claim lost. The category list in the same cell named `TV/set-top`, which no device carries, and left out `wireless` (219 models, third-largest). It now names `wireless` in that slot, so the 25 names are the 25 categories the catalogue actually has. Guards after the edit: syntax-check 333 files OK; docs-show-commands 7/7; help-completeness 8/8; doc-catalog-counts 24/24; canonical-urls 52/52; control-bytes clean; doc citations 350 with the same 5 tolerated suspects as before. Not done here (out of a docs-only PR): README is still unguarded, so this will drift again unless `regen-registry-doc.js` learns to rewrite it or a test reads it.
README: the catalogue holds 2,109 models across 252 vendors, not 1,544 across 245
Some checks failed
CI / Classify the change (pull_request) Successful in 18s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 26s
CI / Docker build (pull_request) Failing after 10m17s
CI / Server smoke test (pull_request) Failing after 10m21s
CI / Test (Node 22) (pull_request) Failing after 10m25s
CI / Test (Node 20) (pull_request) Failing after 10m30s
CI / Test (Node 18) (pull_request) Failing after 10m32s
787fc887bb
The Vendors row was last counted when the catalogue held 1,544 models: the
sentence is a hand-typed copy of the one scripts/regen-registry-doc.js keeps
true in docs/DEVICE_REGISTRY.md, and nothing regenerates README, so it has
been three increments of the catalogue out of date. Loading devices/ now
gives 2,109 models across 252 vendors in 25 categories.

The category list in the same cell also named TV/set-top, which no device
carries, and omitted wireless (219 models, the third-largest category); it
now names wireless in that slot so the 25 names are the 25 categories.
Author
Owner

Merged � verified against main @ 5a4fcd54: loadCatalog(devices) returns 2,109 models / 252 vendors / 25 categories, so the new sentence is true and the old one was 565 models stale. test/doc-catalog-counts.test.js 24/24, check-doc-citations and check-control-bytes clean.

One follow-up, not a blocker: the list now names 24 labels while saying "25 categories", because the catalogue carries a 25th category value ap on exactly one file � devices/huawei/wifi-extender-ax3000.json � alongside wireless (219). Either that file should say wireless (catalogue data, firmware loop) or the README cell needs an AP name back. Worth a one-line guard: doc-catalog-counts.test.js watches docs/DEVICE_REGISTRY.md only, so this README sentence can freeze again exactly as it just did.

Merged � verified against `main` @ `5a4fcd54`: `loadCatalog(devices)` returns **2,109 models / 252 vendors / 25 categories**, so the new sentence is true and the old one was 565 models stale. `test/doc-catalog-counts.test.js` 24/24, `check-doc-citations` and `check-control-bytes` clean. One follow-up, not a blocker: the list now names **24** labels while saying "25 categories", because the catalogue carries a 25th category value `ap` on exactly one file � `devices/huawei/wifi-extender-ax3000.json` � alongside `wireless` (219). Either that file should say `wireless` (catalogue data, firmware loop) or the README cell needs an `AP` name back. Worth a one-line guard: `doc-catalog-counts.test.js` watches `docs/DEVICE_REGISTRY.md` only, so this README sentence can freeze again exactly as it just did.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1584
No description provided.