A no that names one thing must not remove another #1502
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1502
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/no-form-names-what-it-removes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1501
What happened
nois the only undo a technician has. Three of them answered something other than what was asked, and one of them destroyed a setting the command never named.1.
no spanning-tree portfastcleared the bridge priorityThe set form of
spanning-treewas taught to read its verb before its value in #1493. Thenoform never read the word at all:On a switch with
spanning-tree priority 4096:no spanning-tree portfastBridge priority cleared (was 4096), back to the default 32768no spanning-tree costBridge priority cleared (was 4096), back to the default 32768no spanning-tree bpduguardBridge priority cleared (was 4096), back to the default 32768no spanning-tree flurbishBridge priority cleared (was 4096), back to the default 32768Four different questions, one answer, and the answer removed a setting none of them named. The root election is decided by exactly this number, so a lab reconverges to a different root after an operator tried to remove portfast — and
no spanning-tree flurbish(a word that exists nowhere) does it too.2.
helppromised aspeed forced <mbps>form the parser refuses_speed()has never had aforcedkeyword: it parsesautoor a rate (100,1000,1G), and its own usage line saidspeed auto | <mbps>. Onlyhelppromised the other spelling. A documented form the parser refuses is worse than a missing one, because the help is the first thing trusted.3.
no ip access-groupanswered with a sentence that was not oneNo grammar, no subject, and phrased as though it had removed something.
What changes
engine/cli.js: theno spanning-treebranch reads the verb.portfast,cost,bpduguard,bpdufilter,edge,guard,loopguard,root,mst,mode,link-type,backbonefast,uplinkfastare named as not modelled, so there is nothing to remove; an unknown word is quoted back. Onlyno spanning-treeandno spanning-tree prioritytouch the priority. The list is hoisted toSTP_UNMODELLED, shared with the set form, so the two cannot drift apart.help: the row is nowspeed auto|<mbps> … e.g. \speed 100`, `speed 1G``.no ip access-group:% No access list 101 applied in on Gi0/0/% No access list applied in or out on Gi0/0— the shape the sibling refusals already use (No hostname set,No DHCP pool named nope). My first attempt read better (Access list 101 is not applied in …) and failedtest/config-undo.test.js, which had already pinned the house shape; the neighbours won.Verification
test/no-command-touches-only-what-it-names.test.js— 7 checks:config.stpPriorityat 4096, say nothing about clearing, name the word that was asked, name the tunable that does exist — and are checked through two more doors (show spanning-treeandshow running-config);portfastis refused as unmodelled, not as an unknown word;no spanning-treeandno spanning-tree prioritystill clear, and saycleared (was 8192);no spanning-treewith nothing set still saysNo bridge priority set;helpno longer containsspeed auto|forcedand does containspeed auto|<mbps>;speed 100,speed autoaccepted;speed forced 100refused by naming what it takes;unapplied in, binding actually gone).With the old handler: 3 passed / 4 failed. With this change: 7/7.
Full suite 248 suites / 9135 assertions / 0 failed; syntax 318 files; canonical URLs 2857 files;
config-undo48/48,help-completeness8/8,no-command-swallows-a-word21/21,command-answers-the-question27/27,stp-priority41/41,skip-audit15/15.Not claimed
The stale
no spanning-tree <verb>behaviour for sub-commands this console does not model is refused, not implemented:portfaststill does not exist as a feature, and this change does not add it.nothat names one thing must not remove anotherThe auto-rebase job failed. This is a problem with the automation, not with this change.
The run is at http://10.0.10.20:3000/jaylouisw/packetforge/actions/runs/2974. Nothing was pushed, so the branch is exactly as you wrote it.
Ready, and blocked on the host's disk - not on this change.
The tree is verified: 248 suites / 9135 assertions / 0 failed, syntax 318 files, canonical URLs 2857,
config-undo48/48,help-completeness8/8,no-command-swallows-a-word21/21,command-answers-the-question27/27,stp-priority41/41,skip-audit15/15, and the new suite 7/7 (3 passed / 4 failed against the old handler).Every route to
mainis closed at the moment, all of them byNo space left on device:500-could not write config file .../pull.git4033333395/.git/config: No space left on device(succeeded on a retry 30 s later)201, thenClassify the changefailed500ENOSPC, then405 Please try again lateron fourteen consecutive attempts405,mergeable=Falsemaindirectly! [remote rejected] main -> main (pre-receive hook declined)A merge needs a temporary clone to compute mergeability, and that clone cannot be written, so
mergeablereadsfalseand the endpoint answers 405 instead of saying why. The same thing happened on #1498 and #1500 earlier today; both landed once a free window appeared.Nothing to fix here. This will land on the first attempt that finds space. The space itself needs the host:
docker system dfthendocker builder prune- my #1500 change stops the next fill, it cannot reclaim what is already gone.Amended: this PR now also records what it cost to discover, in
docs/FORGE_TROUBLESHOOTING.md(§ When the volume is full, every retry leaves another half-clone).The three defects are unchanged and still verified (suite 248 / 9135 / 0, syntax 318,
no-command-touches-only-what-it-names7/7). The addition is the operational half:500from the clone path, a405 Please try again lateron merge with"mergeable": false, and a pull request whoseneeds:jobs are never created;pull.git<random>half-clone underdata/tmp/local-repo/. My own retry loop yesterday made the outage worse: a dozen attempts against a 48 MB repository is a few hundred megabytes of garbage. The page now says: one attempt tells you the answer, the tenth only lengthens the wait;df,du -sh data/tmp/local-repo/*,docker system df,docker builder prune), and the reminder that the action queue does not recover without a restart.docs/CI.mdnow points at that section from the docker-job rule, and the two_help()citations indocs/BGP-POLICY.mdare repinned tocli.js:4305(the hoistedSTP_UNMODELLEDlist moved them).check:doc-citationsreports only the knowntest/bgp.test.js:452false positive.Still cannot land: one merge attempt after this push returned
405,mergeablestillfalse. Per the lesson above I am not retrying it in a loop; it will go on the first attempt that finds space.?is a keypress in every prompt, andexitwalks one level at a time #1504?is a keypress in two prompts and a syntax error in the other three;exitat#never leaves##1503Rebased onto current
main(1b1e1287) locally — the only conflict wasdocs/CLI.md, where both branches appended a section; both are kept, #1501's first and #1503's second. With the rebase: full suite 249 suites / 9144 assertions / 0 failed,no-command-touches-only-what-it-names7/7,help-key-works-in-every-prompt9/9, syntax 319 files, citations clean apart from the knowntest/bgp.test.js:452false positive.The rebased head could not be pushed. Two attempts 35 s apart both answered
! [remote rejected] fix/no-form-names-what-it-removes -> fix/no-form-names-what-it-removes (failed to update ref)— a loose ref cannot be written, which is the full volume again (the same class of failure ascouldn't set 'refs/heads/...'). The remote branch is therefore still at11306943, andmergeablereadsfalse.Nothing to change in the branch. It will go as soon as the volume has room for a ref and a clone; I am not retrying in a loop, for the reason recorded in
docs/FORGE_TROUBLESHOOTING.md— every failed attempt leaves a half-clone and lengthens the wait.1130694360to0a3a99d43a0a3a99d43af2802f9aa5no spanning-treeexists - the doc said it did not #2061