A frame that died named the door that was shut #1438
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1438
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/flood-refusal-reason"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1437
A frame that left a switch by no port said one sentence whatever had refused it:
no egress ports in VLAN <vid>. On a switch whose only other port the spanning tree had blocked, that is false twice — the port is in the VLAN, and the box already prints the truth inshow spanning-tree:Two surfaces on one box, disagreeing about one frame. The counter is the one an operator acts on, so the VLAN gets re-checked and the VLAN was never the problem; it is also the sentence
_lastDiscard()hands a failedping.The change
_forwardL2()already knew why each candidate was refused — it just threw the reason away. It now records it, and_noEgressReason()names the door that was shut:no egress ports: spanning tree blocks Fa0/1no egress ports: the only other port is a member of the ingress port-channelno egress ports in VLAN 10(kept — this was always true)Where the reason sits in
_lastDiscard()did not move. Naming the tree does not make it a different kind of cause: a block on a redundant path is not the reason apingfailed, so ranking it with the port causes (above silence and above policy) would have replaced one lie with another. The rank slot now matches both wordings (no egress ports) instead of only the VLAN one, so priority is byte-for-byte what it was.Evidence
test/flood-refusal-reason.test.js, 24 checks:alternate blocking;show interfacescarries it in the port's drop row;drops.byReasonuses the same sentence as the console, counted once (not once per blocked candidate);VLAN 10, withswitchport: trunkbeside it agreeing;_lastDiscard()still prefers silence over it and still prefers it over policy — unchanged.Reverting
engine/simulator.jsfails 11/24 (✗ the reason does not claim a VLAN problem,✗ the payload counts the same sentence the console prints,✗ the hairpin names the bundle, …).Docs:
docs/ARCHITECTURE.md§ "A frame that died named the door that was shut".