A test that waits says what it waited for (#1415) #1416
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1416
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/ws-flake"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1415.
CI's
Test (Node 22)went red onebc81a9eand again on the #1414 pull request while Node 18 and Node 20 stayed green, and the entire diagnosis available from the run was:Reproduced here under Node 22.14: one full-suite run failed
state-payload-shape(0 passed, 1 failed, no summary line); the next two runs of the same suite on the same build passed 21/21. A flake - but the message names neither the frames the client received nor anything the server said, so no run could ever prove that.Two changes, both in the harness:
note: the connect frame needed a second socket (...), because a flake silently absorbed is a flake nobody fixes.Verified:
state-payload-shape21/21 on Node 24 and on Node 22.14; full suite 208 suites, 7,989 assertions, 0 failed on both; syntax 276 files OK.