show lldp marks stale neighbours, and its columns no longer run together (#1265) #1266
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1266
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/show-lldp-stale"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
show lldpmarks stale neighbours, and its columns no longer run togetherFixes #1265.
What was wrong
Pull a cable and the table did not change. Shut the far port and it still did not change. And the row itself
was unreadable, because
Neighbourwas padded to 20 characters and a real device name is 55:show arp(#1254) andshow mac address-table(#1256) were both taught to mark an entry whose port can nolonger carry a frame. This table — the third one that reports learned state — was not.
Now
this model has no clock to age it with. The Local port carries the reason instead, in the same sentence
the other tables use —
(down: link down),(down: peer shut down),(administratively down);_staleNote(iface)and the port is resolved throughdev.resolveIface(), so avendor spelling resolves and a port that no longer exists reads
(gone)instead of a device being inventedfor it;
next column whatever the catalogue grows to;
(none - no LLDP has been heard on any port).Evidence
test/show-lldp.test.js— 23 checks. The parser reads rows by the table's own header offsets, not by aregex, so it fails on unreadable output as well as on a missing mark:
asserted to be longer than 20 characters, so the defect is reproducible rather than assumed; nothing is
concatenated (
r1Fa0/1must not appear);in the same table stays unmarked — the mark is per row, not per table;
(gone);port appears twice with the unusable row marked;
Reverting
engine/cli.jsfails 12 of the 23.docs/CLI.mdgains "Readingshow lldp" and the command in the table.Suite: 146 suites, 6,217 assertions, 0 failed.
show lldpmarks stale neighbours, and its columns no longer run together (#1265)