A readiness wait is a deadline, not an attempt count (#1242) #1243
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1243
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/readiness-deadline"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A readiness wait is a deadline, not an attempt count
Fixes #1242.
test/server-immutable-json.test.jswent red in a full run withserver did not start, and passed on itsown. The cause was the wait, not the suite:
Six seconds is enough for
server/index.jsto load and serialise a 4.4 MB catalogue on an idle machine andnot enough when the runner is executing other suites. Worse, the failure said nothing: the child's output
was piped and discarded, so "the server crashed" and "the server is slow" produced the same one-line error.
Now
twelve lines of output.
Evidence
Three checks added to the same file (21 → 25):
fine here, so this is the margin check;
child said: boom).Both are real children on real ports, not mocks: the slow one is a
node -ethat binds after a timeout.Suite: 135 suites, 5,870 assertions, 0 failed.