Audit closed requests against the catalogue: the six wrong closes were invisible by design #1210
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1210
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/closed-issue-audit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Six requests were closed as "impossible to model - no Ethernet port" while every one of those devices was already in
devices/: #54, #167, #360, #362, #374, #387. The sweeper could not catch it, and the reason is structural: it only ever looks at open issues. Closing a request removes it from every automated view, so a wrong close is permanent, invisible, and looks exactly like work that was done.scripts/check-closed-issues.jswalks the other side of the ledger:Against the live tracker (120 most recent closed device requests): 52 answered with evidence, 0 silent, 68 unmatched.
Three decisions worth naming, because each is a way the audit could become the problem it looks for:
[Device]: ...) unless--all. A bug report mentioning an OLT - "OLTs promise 10G SFP+ uplinks they do not model" - matched an OLT and produced a finding that meant nothing.main(schedules never reach a runner here) and never fails the build: a report nobody can act on because the pipeline went red is worse than no report.It never reopens or closes anything - the action stays with a person; this only makes sure the person is looking. Documented in
docs/RESOLUTIONS.md.17 checks in
test/closed-issues-audit.test.js, including all six real cases against the live catalogue. Suite: 116 suites, 5,378 assertions, 0 failed.