Auto-rebase: put the job guard back the way it was, because PRs stopped dispatching #1172
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1172
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/rebase-guard-null"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The last change here added two clauses to this job's
if:— a state check and a null check onhead.repo. After it landed, pull requests stopped producing workflow runs entirely: the checks satpendingand never resolved, on four separate pull requests, while other branches on the same runner dispatched normally.I could not establish whether the multi-clause expression was the cause or whether it coincided with the runner being saturated. What I do know:
So it's back to the single comparison with a known history, and the reason is recorded in the file so nobody re-adds it without testing dispatch first.
What stays from the previous change
FORGEJO_TOKEN || GITHUB_TOKEN || github.token).::warning::instead of reddening somebody's pull request.Those are independent of the guard and were not implicated.
Full suite: 113 suites, 5311 assertions, 0 failed.
The last change here added two clauses to this job's `if:` - a state check and a null check on `head.repo`. After it landed, pull requests stopped producing workflow runs entirely: the checks sat `pending` and never resolved, on four separate pull requests, while other branches on the same runner dispatched normally. I could not establish whether the multi-clause expression was the cause or whether it coincided with the runner being saturated. What I do know is that the failure mode is indistinguishable from a queue that never drains, and that **a skipped job and a job that never exists look identical from the pull request** - except that only one of them blocks a merge forever. A guard that might be the reason nothing runs is not worth the null-safety it buys. So it is back to the single comparison with a known history, and the reason is recorded in the file so nobody re-adds it without testing dispatch first. What stays from the previous change: the three-way token fallback, and every failure path exiting 0 with a `:⚠️:` instead of reddening somebody's pull request. Those are independent of the guard and they were not implicated. Full suite: 113 suites, 5311 assertions, 0 failed.The auto-rebase job failed. This is a problem with the automation, not with this change.
The run is at the Actions tab. Nothing was pushed, so the branch is exactly as you wrote it.