Stop asking the event for inputs it will never have #1087

Merged
jaylouisw merged 1 commit from ci/auto-rebase-drop-inputs into main 2026-11-08 16:26:18 +00:00
Owner

Twenty runs, none ever started. Not on schedule, not on workflow_dispatch with inputs supplied, not on push after #1086 removed the concurrency group.

So #1086 was wrong, and here is the evidence rather than another hypothesis:

run trigger created started
738 workflow_dispatch, inputs supplied 16:11:27 never
737 schedule 16:10:41 never
711 push 15:57:31 never

Meanwhile ci.yml dispatches normally on the same runner, same runs-on, same trigger types. The job row exists in both cases — status 5, runs_on ["ubuntu-latest"], task_id 0 — so the difference is not in the job, it is in whatever decides to turn the job into a task.

The one thing left in this file that ci.yml does not do is evaluate github.event.inputs. An expression that cannot be evaluated at job-preparation time produces exactly this shape: a job that exists, is pending, and never becomes a task.

It bought nothing — the two variables fed batch and settle_seconds, both of which the script already defaults. They are gone, and the defaults are literals now.

If the next push to main still never starts a run, the problem is not expressions either. At that point the honest move is to stop guessing at this file and read Forgejo's dispatcher, and I will say so rather than opening a fourth variation of the same guess.

Twenty runs, **none ever started**. Not on schedule, not on `workflow_dispatch` with inputs supplied, not on push after #1086 removed the concurrency group. So #1086 was wrong, and here is the evidence rather than another hypothesis: | run | trigger | created | started | |---|---|---|---| | 738 | workflow_dispatch, inputs supplied | 16:11:27 | never | | 737 | schedule | 16:10:41 | never | | 711 | push | 15:57:31 | never | Meanwhile `ci.yml` dispatches normally on the same runner, same `runs-on`, same trigger types. The job row exists in both cases — `status 5`, `runs_on ["ubuntu-latest"]`, `task_id 0` — so the difference is not in the job, it is in whatever decides to turn the job into a task. The one thing left in this file that `ci.yml` does not do is evaluate `github.event.inputs`. An expression that cannot be evaluated at job-preparation time produces exactly this shape: a job that exists, is pending, and never becomes a task. It bought nothing — the two variables fed `batch` and `settle_seconds`, both of which the script already defaults. They are gone, and the defaults are literals now. **If the next push to main still never starts a run, the problem is not expressions either.** At that point the honest move is to stop guessing at this file and read Forgejo's dispatcher, and I will say so rather than opening a fourth variation of the same guess.
Stop asking the event for inputs it will never have
All checks were successful
CI / Test (Node 18) (pull_request) Successful in 1m35s
CI / Test (Node 20) (pull_request) Successful in 1m28s
CI / Server smoke test (pull_request) Successful in 33s
CI / Docker build (pull_request) Successful in 37s
CI / Test (Node 22) (pull_request) Successful in 1m31s
324100e5da
Twenty runs, none ever started. Not on schedule, not on workflow_dispatch with inputs supplied, not on push after #1086 removed the concurrency group. The run row appears, the job row appears with runs_on [ubuntu-latest] and task_id 0, and no task is ever created - while ci.yml dispatches normally on the same runner with the same runs-on and the same trigger types.

The last thing in this file that ci.yml does not do is evaluate github.event.inputs. That context is null for every trigger except workflow_dispatch, and dispatching with inputs supplied behaved identically. An expression that cannot be evaluated while a job is being prepared would produce exactly what the database shows: a job that exists, is pending, and is never handed to a runner.

The two expressions fed batch and settle_seconds, both of which the script already defaults. So they bought nothing the defaults did not, and they are gone; the defaults are now literals in the script.

If the next push to main still never starts a run, then the problem is not expressions either, and the honest next step is to stop guessing at this file and read Forgejo's dispatcher.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-08 16:15:22 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1087
No description provided.