Say why the server will not start, and where to report it #1067
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1067
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/server-will-not-start"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The most common reason PacketForge does not start is that a port is already taken. Until now that reached the user as a raw
EADDRINUSEstack trace — at the one moment the web UI, and with it the Report a bug button added in #1065, does not exist.server/startup-error.jsturns the failures a normal person actually hits into sentences:EADDRINUSEEACCESSelf-inflicted failures (
EACCES,EADDRNOTAVAIL) deliberately do not invite a bug report — sending someone to open an issue because they typedPORT=80wastes their time and ours.Why the message and not the button
The reporting path has to work in exactly the case where the UI is absent. So the report link is a prefilled
issues/newURL carrying a template that asks for the terminal output and how they started it, and the message prints it.Tests
test/startup-error.test.js, 25 checks, in two halves:undefinednever reaches the output.Local:
node scripts/syntax-check.js164 files OK ·node test/startup-error.test.js25/25.Unrelated, pre-existing failure on main
While running the suite I found
test/mikrotik-naming.test.jsred onmainfrom #776 — the RDS2216 declaresSFP+281..283withsfp28media and lowercaseqsfp281. That is a separate device-data bug and gets its own PR, not this one.