ci: drop GitHub-legacy workflows (CodeQL + GitHub ci.yml fail on Forgejo) #1059

Merged
jaylouisw merged 1 commit from ci/remove-github-workflows into main 2026-11-08 13:54:42 +00:00
Owner

Forgejo 11 reads .github/workflows/ in addition to .forgejo/workflows/, so the GitHub-legacy files were running and failing:

  • codeql.yml: github/codeql-action is GitHub-only -> Analyze job fails 75x
  • ci.yml (GitHub): Docker build + Workflow lint jobs with if: github.server_url guards that do not skip on Forgejo

Removes the whole .github/workflows/ tree. CI now lives solely in .forgejo/workflows/ci.yml (and the new auto-rebase.yml).

Forgejo 11 reads .github/workflows/ in addition to .forgejo/workflows/, so the GitHub-legacy files were running and failing: - codeql.yml: github/codeql-action is GitHub-only -> Analyze job fails 75x - ci.yml (GitHub): Docker build + Workflow lint jobs with if: github.server_url guards that do not skip on Forgejo Removes the whole .github/workflows/ tree. CI now lives solely in .forgejo/workflows/ci.yml (and the new auto-rebase.yml).
ci: drop GitHub-legacy workflows
All checks were successful
CI / Server smoke test (pull_request) Successful in 42s
CI / Docker build (pull_request) Successful in 11s
CI / Test (Node 18) (pull_request) Successful in 1m46s
CI / Test (Node 20) (pull_request) Successful in 1m47s
CI / Test (Node 22) (pull_request) Successful in 2m2s
d2ed975f6b
codeql.yml (github/codeql-action) and the GitHub ci.yml are GitHub-only and fail on Forgejo, which also reads .github/workflows/. Forgejo-first: CI lives solely in .forgejo/workflows/.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-08 13:41:05 +00:00
Author
Owner

Why this PR is the fix for the red Docker build check

Verified from the runner log of run 173 (PR #915, job index 4, Docker build):

/var/run/act/workflow/1.sh: line 2: docker: command not found
exitcode '127': command not found
Job 'Docker build' failed

The runner image is node:20-bookworm, which has no docker binary. The legacy
.github/workflows/ci.yml docker job runs a bare docker build, so it fails with
exit 127 on every pull request whose head still predates .forgejo/workflows/ci.yml.

Two things made this worse than a single red check:

  1. The if: github.server_url == 'https://github.com' guard on the legacy jobs does
    not skip them on Forgejo — the jobs execute and fail.
  2. Because the failures are in a workflow that cannot pass here, they are
    indistinguishable from a real regression in the queue.

Scale of the problem across open PRs (from the actions task history): Docker build
89 failures / 3 successes, Analyze (CodeQL) 78/78 failures. Server smoke test
92/92 green, Test ~73/93 per Node version.

Deleting .github/workflows/ leaves .forgejo/workflows/ci.yml, whose docker job
probes command -v docker first and reports "no daemon" instead of failing. That is
the behaviour the queue needs.

Landing this also stops the queue growing with jobs that can never pass on this host.

## Why this PR is the fix for the red `Docker build` check Verified from the runner log of run 173 (PR #915, job index 4, `Docker build`): ``` /var/run/act/workflow/1.sh: line 2: docker: command not found exitcode '127': command not found Job 'Docker build' failed ``` The runner image is `node:20-bookworm`, which has no `docker` binary. The legacy `.github/workflows/ci.yml` docker job runs a bare `docker build`, so it fails with exit 127 on every pull request whose head still predates `.forgejo/workflows/ci.yml`. Two things made this worse than a single red check: 1. The `if: github.server_url == 'https://github.com'` guard on the legacy jobs does **not** skip them on Forgejo — the jobs execute and fail. 2. Because the failures are in a workflow that cannot pass here, they are indistinguishable from a real regression in the queue. Scale of the problem across open PRs (from the actions task history): `Docker build` 89 failures / 3 successes, `Analyze` (CodeQL) 78/78 failures. `Server smoke test` 92/92 green, `Test` ~73/93 per Node version. Deleting `.github/workflows/` leaves `.forgejo/workflows/ci.yml`, whose docker job probes `command -v docker` first and reports "no daemon" instead of failing. That is the behaviour the queue needs. Landing this also stops the queue growing with jobs that can never pass on this host.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1059
No description provided.