docs(cli): a trunk pruned to nothing is committed, not refused (#2420 follow-up) #2429
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2429
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1121-1347"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#2420 changed the console:
switchport trunk allowed vlan removethat takes every frame-carrying VLAN is now accepted and committed (leaving1002-1005, or the empty listnonestores). It updated the later paragraphs of docs/CLI.md but left two claims behind.docs/CLI.md (line 2147) still said: "A
removethat would empty the list is refused rather than committed, with both ways out named — a trunk carrying no VLAN is not something to arrive at by subtraction." That refusal no longer exists:engine/cli.js:3977-3982storesallowedVlans: []and answersallows no VLANs (removed …); the comment there says the state is "stored the same way rather than refused". The sentence now matches that, and the followingremove 10transcript (unchanged) still replays.docs/ARCHITECTURE.md (line 1130) said
test/trunk-allowed-remove-from-all.test.jswas "47 checks"; it is 55 (node test/trunk-allowed-remove-from-all.test.js-> 55 passed). #2420 added eight checks (+8: 47 -> 55) and restated what the suite pins.Guards before and after, unchanged:
scripts/syntax-check.js535 files OK; docs-cli-transcript 9/9; docs-show-commands 7/7; help-completeness 8/8; no-form-help-key 81/81;scripts/check-control-bytes.jsclean;scripts/check-doc-citations.js380 citations, rc 0.Docs only; no engine or test changes.