ci(auto-rebase): the tick fetches its own tree, so a dead data.forgejo.org cannot cancel setup #2374
Closed
jaylouisw
wants to merge 1 commit from
fix/1121-0532 into main
pull from: fix/1121-0532
merge into: jaylouisw:main
jaylouisw:main
jaylouisw:rev/1121-1812
jaylouisw:catalogue/1121-1822
jaylouisw:docs/1121-1817
jaylouisw:catalogue/1121-1752
jaylouisw:docs/1121-1747
jaylouisw:rev/1121-1742
jaylouisw:catalogue/1121-1722
jaylouisw:rev/1121-1712
jaylouisw:docs/1121-1717
jaylouisw:catalogue/1121-1652
jaylouisw:rev/1121-1642
jaylouisw:docs/1121-1647
jaylouisw:ci/1121-1646
jaylouisw:ci/1121-1427
jaylouisw:rev/1121-1412
jaylouisw:catalogue/1121-1422
jaylouisw:docs/1121-1417
jaylouisw:catalogue/1121-1352
jaylouisw:rev/1121-1342
jaylouisw:docs/1121-1347
jaylouisw:rev/1121-1212
jaylouisw:catalogue/1121-1222
jaylouisw:docs/1121-1217
jaylouisw:ci/1121-1027
jaylouisw:catalogue/1121-1022
jaylouisw:rev/1121-1013
jaylouisw:docs/1121-1017
jaylouisw:catalogue/1121-0852
jaylouisw:rev/1121-0842
jaylouisw:docs/1121-0847
jaylouisw:ci/1121-0827
jaylouisw:catalogue/1121-0822
jaylouisw:rev/1121-0812
jaylouisw:catalogue/1121-0752
jaylouisw:rev/1121-0742
jaylouisw:docs/1121-0747
jaylouisw:catalogue/1121-0722
jaylouisw:docs/1121-0717
jaylouisw:rev/1121-0712
jaylouisw:rev/1121-0642
jaylouisw:plan/1121-0637
jaylouisw:ci/1121-0627
jaylouisw:catalogue/1121-0622
jaylouisw:rev/1121-0612
jaylouisw:docs/1121-0617
jaylouisw:plan/1120-0337
jaylouisw:docs/1120-0347
jaylouisw:rev/1119-1942
jaylouisw:rev/1119-1912
jaylouisw:catalogue/1119-1752
jaylouisw:docs/1119-1347
jaylouisw:catalogue/1119-1352
jaylouisw:fix/1119-1232
jaylouisw:fix/1119-0602
jaylouisw:catalogue/1119-0452
jaylouisw:catalogue/1119-0422
jaylouisw:docs/1119-0417
jaylouisw:fix/1119-0202
jaylouisw:catalogue/1119-0222
jaylouisw:rev/1119-0042
jaylouisw:catalogue/1118-2252
jaylouisw:docs/1118-2047
jaylouisw:catalogue/1118-2152
jaylouisw:fix/1118-2037
jaylouisw:ci/1118-2027
jaylouisw:docs/1118-1416
jaylouisw:fix/1118-1006
jaylouisw:catalogue/1118-0326
jaylouisw:catalogue/1117-2326
jaylouisw:catalogue/1117-0025
jaylouisw:catalogue/1116-1730
jaylouisw:fix/1523-speed-downgrade-one-end
jaylouisw:fix/enable-required-and-empty-pipe-help
jaylouisw:land-all-v5
jaylouisw:land-all-v4
jaylouisw:land-all-v3
jaylouisw:land-all-v2
jaylouisw:land-all
jaylouisw:fix/board-id
jaylouisw:fix/stated-range
jaylouisw:fix/no-form-names-v2
jaylouisw:fix/voice-vlan
jaylouisw:devices/catalogue-batch
jaylouisw:devices/powerline-moca
jaylouisw:devices/firewalls-enterprise
jaylouisw:devices/pon-splitters
jaylouisw:devices/nvr-and-taps
jaylouisw:devices/four-nvr-models
jaylouisw:fix/contributing-exemption
jaylouisw:fix/stale-github-urls
jaylouisw:ci/cancel-superseded-runs
jaylouisw:gh/1438
jaylouisw:device/uisp-console-lbe-xr
jaylouisw:gh/1442
jaylouisw:docs/readme-current-counts
jaylouisw:feat/device-ubiquiti-wave-fiber-onu
jaylouisw:fix/address-ownership
jaylouisw:feat/vrrp-in-path
jaylouisw:fix/merge-research-duplicate
jaylouisw:docs/hybrid-patch-current
jaylouisw:fix/audit-port-template
jaylouisw:fix/2930f-jl256a-uplinks
jaylouisw:feat/dhcp-in-path
jaylouisw:feat/hackgpon-ubiquiti-uisp-fiber-xgs
jaylouisw:feat/hackgpon-adtran-sdx-621
jaylouisw:tool/issue-duplicate-sweep
jaylouisw:feat/device-mikrotik-rb433ah
jaylouisw:feat/hackgpon-ma5671a
jaylouisw:issues/categories-and-labels
jaylouisw:ci/run-every-suite-locally
jaylouisw:chore/http-smoke
No reviewers
Labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2374
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1121-0532"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #2366.
What was wrong
The runner pre-clones every
uses:action at dispatch, before a step of the job runs.auto-rebase.ymlwas the last workflow in this repository carrying one, so when this host lost egress todata.forgejo.orgon 2026-11-20 every tick failed inSet up job- sixteen in a row, 7 h 20 m with no rebase and no arming backstop, in twelve-line logs that no step of the workflow could write to.What changed
.forgejo/workflows/auto-rebase.yml: theCheck out the queuestep (uses: actions/checkout@v4) is replaced byFetch the queue-git init+ one--filter=blob:nonefetch ofmain, the shapepr-rebase.ymlruns ~750 times a day. Same commit, same tree, sameif:gate onsteps.room.outputs.room/steps.queue.outputs.work/steps.queue.outputs.push, credentials still only inoriginfrom the push prologue onwards. The fetch is bounded (90 stimeout, 1 kB/s low-speed abort) like every other call in the file.test/ci-disk-hygiene.test.js: the #1508 invariant now reads "the room guard precedes whatever materialises the tree" (actions/checkout or agit fetch), withguardAt < checkoutAtandgated()unchanged; a new case asserts therebasejob runs nouses:at all, so the dependency cannot come back. That new case fails on main and passes here.Verification
mainwithactual: ['uses: actions/checkout@v4'].uploadpack.allowFilter: blobless fetch,checkout -B auto/1 origin/<ref>,merge-base --is-ancestor,rebase,diff --quietand--force-with-leasepush all succeed from the object-less clone (blobs fetched on demand, the propertypr-rebase.ymlalready relies on).node scripts/syntax-check.js: 515 files, all OK.npm test: 435 suites, 14 624 assertions, 0 failed.Cost
Run 4968 (dispatch from a branch doing exactly this) took 5 s where run 4967 from
mainwith the action took 17 s on the same "no mergeable open pull requests" answer - 3.8 s of action clone plus the 9.2 s full-depth fetch of 792 refs measured in run 4962.Not done
Nothing outstanding for the issue. While in the file I noticed the
Rebase and armstep still carries two long comment paragraphs aboutgithub.event.inputsand about a run-token push duplicating a later paragraph on the same subject; consolidating those is a separate docs cleanup, left alone here.Conflicted after #2370 landed
mainat1cbc0b62(squash of #2370,ci/1121-0502) now carries the same rewrite this PR makes, so the merge reports conflicts in both files:.forgejo/workflows/auto-rebase.yml— both branches replace the same comment block and drop the same second fetch; the prose is a different narrative of the same change, not adjacent insertions.test/ci-disk-hygiene.test.js— same story: #2370 already relaxed the "job must still check out" assertion.git merge-tree origin/main fix/1121-0532names stages 1/2/3 for both paths. This is a behaviour/wording decision (which narrative of the tick survives), not a mechanical conflict, so the surgery loop is not resolving it.Needs the author: rebase
fix/1121-0532onmainand keep one narrative. The PR is green 7/7 one0832da2but that run is a merge against the pre-2370 tree, so it cannot be merged as-is. Branch is 4 behind and the head status will have to be re-armed after the force-push.Closing as superseded — no merge, no rebase.
The fix this PR carries is already on
main: commit1cbc0b62("ci(auto-rebase): the tick checks out with git, so an unreachable forge cannot stop setup (#2366)"), which landed as #2370 and closed #2366. It does the same thing this branch does —actions/checkoutremoved, the tree built withgit init -q .+git remote add origin+ a bloblessgit fetch, credentials per command through an inline helper rather thanhttp.extraheader.I merged
origin/maininto this head locally to classify the red/conflicted state. It is not a code conflict: both sides are prose about the same rewrite, and every conflict hunk is a comment block narrating #2366 from two angles (.forgejo/workflows/auto-rebase.yml,test/ci-disk-hygiene.test.js). There is no behaviour here thatmainlacks — the step bodies are equivalent.One thing
maindoes not carry, in case it is worth a fresh PR: this branch generalisesisCheckout()intest/ci-disk-hygiene.test.jsto also match agit ... fetchstep, and adds a test asserting therebasejob runs nouses:at all. That is a test-strength improvement independent of the fix; file it on its own against currentmainand it should land clean.Author: nothing to rebase — the branch can go.
Pull request closed