auto-rebase should stand down when the host has no room, instead of failing every ten minutes #1508
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1508
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
.forgejo/workflows/auto-rebase.ymlruns onschedule: '*/10 * * * *'. While the volume is full (#1507) every rundoes an
actions/checkoutof this repository into the runner's workspace, then fails at the first write. Measured onthe instance today:
So the automation spends the bytes it is waiting for, six times an hour, and the red is indistinguishable from a real
regression until you look at the timestamps.
What should change
A first step that measures free space and stands down with a clear sentence, before the checkout:
Exiting 0 is deliberate: a host out of disk is not a code failure, and a green tick with the reason in the log is
honest, while a red X six times an hour trains everyone to ignore the workflow. The same guard belongs in the other
workflows that check out (
ci.ymlalready bounds what it writes, which is the other half of the same problem).Why not now
Landing is blocked:
POST /pullsanswers500 … No space left on deviceand a direct push tomaincannot writeits ref. This is recorded so the change is not lost, and it is small enough to land with the queue in #1501/#1505/#1506.
One more thing this issue should fix while it is in there: the comment at the top of
auto-rebase.ymlis nolonger true, and it is the reason the schedule was left in place.
It says:
The run ledger says otherwise now:
Rebase open PRs and arm auto-mergesucceeds on the ten-minute boundaries(
07:50:42 success, and 479 successes in the recent history), and the failing ones sit on the same boundaries(
08:00,08:20, …09:40). Scheduled runs reach a runner; they are failing on the writes, which is #1507.So the comment should be corrected in the same pull request as the disk guard, and the
schedule:block is then areal choice rather than a safety net that never fires:
push: branches: [main]is the trigger that matters.dfas zero and silently switches itself off #1651dfmust not read as zero free space (#1651) #1652