closed-issue audit: a close that contradicts the blocked-request record is a finding #1901

Merged
jaylouisw merged 1 commit from fix/1117-2105 into main 2026-11-17 22:02:25 +00:00
Owner

Refs #742, #743 — both are reopened by this PR and neither is answered by it.

The two closes were a parser, not a decision

#742 closed at 17:07:57 with the merge of #1873, 83 seconds after its own last comment said the issue stays open. #743 closed at 16:06:14 with the merge of #1867, whose comment above it says the same thing. There is no spec behind either: research/open-device-requests.json still lists both as blocked on a value the vendor does not publish, and nothing was built.

The tracker reads a close keyword followed by an issue number anywhere in a pull request body and ignores the sentence around it. #1867's opening line disclaimed the closure; #1873 carried a heading naming the condition that would end the block. Both were executed as instructions to close. The exact phrasings are quoted with #N placeholders in this body on purpose — reproducing either one beside a live number re-arms it, which is also why the reopen comments were edited after posting.

What changes

  1. A blocked verdict. scripts/check-closed-issues.js now reads research/open-device-requests.json — this project's own record of the requests it cannot model — and reports any closed issue still in it. Checked before the catalogue: an entry can be matched by a spec and still declared blocked, and that is two contradictions, not an answer. --strict fails on it, --json carries it, and a mirror that will not parse prints a warning rather than quietly turning the newest check off.

  2. The window now contains the newest close. The list was fetched in the instance's default order, by issue number, so #742 sat about 1,100 rows below the 120 the CI job reads and no practical --limit reached it. It is now sorted by most-recently-updated, which puts a close from a minute ago on page 1.

  3. Silent findings name the file. loadCatalog() returns spec objects without the path that produced them, so every live silent finding printed -> null — a report nobody can act on. The walk is repeated locally for that one field.

Evidence, live, --limit 60 --max-age-days 2

Before: no blocked count, and every finding ended -> null.
After:

closed while still blocked     : 2

  #742   [Device]: Huawei OceanProtect E8000 Backup S -> no spec exists
  #743   [Device]: Huawei OceanProtect X8100/X9100 Ba -> no spec exists

  #804   [Device]: OptiXtrans E6608T    -> devices/huawei/optixtrans-e6608t.json
  #760   [Device]: FS NC8200-4TD        -> devices/fs/nc8200-4td.json

Tests and gates

  • test/closed-issues-audit.test.js: 31 passed, 0 failed (17 before; the new cases pin the two incident issues against the live mirror file, the blocked-before-catalogue precedence, an unparsable/misshapen mirror, the sort parameter, and the path the loader drops).
  • node scripts/syntax-check.js: 394 files, all OK. npm run check:bytes: clean.
  • test/request-queue.test.js 23 passed, test/skip-audit.test.js 15 passed — the other suites that touch this script.
  • Full node scripts/run-tests.js is running on the branch; this PR touches one standalone script and the docs, not engine code.

Docs

docs/RESOLUTIONS.md described three counts and now describes four, with the mechanism and the ordering reason. CONTRIBUTING.md gains "What a pull request body closes": write Refs #N, keep the number away from those nine words everywhere else in the body, including headings and quoted comments.

Refs #742, #743 — both are reopened by this PR and neither is answered by it. ## The two closes were a parser, not a decision #742 closed at 17:07:57 with the merge of #1873, 83 seconds after its own last comment said the issue stays open. #743 closed at 16:06:14 with the merge of #1867, whose comment above it says the same thing. There is no spec behind either: `research/open-device-requests.json` still lists both as blocked on a value the vendor does not publish, and nothing was built. The tracker reads a close keyword followed by an issue number **anywhere** in a pull request body and ignores the sentence around it. #1867's opening line disclaimed the closure; #1873 carried a heading naming the condition that *would* end the block. Both were executed as instructions to close. The exact phrasings are quoted with `#N` placeholders in this body on purpose — reproducing either one beside a live number re-arms it, which is also why the reopen comments were edited after posting. ## What changes 1. **A `blocked` verdict.** `scripts/check-closed-issues.js` now reads `research/open-device-requests.json` — this project's own record of the requests it cannot model — and reports any closed issue still in it. Checked before the catalogue: an entry can be matched by a spec *and* still declared blocked, and that is two contradictions, not an answer. `--strict` fails on it, `--json` carries it, and a mirror that will not parse prints a warning rather than quietly turning the newest check off. 2. **The window now contains the newest close.** The list was fetched in the instance's default order, by issue number, so #742 sat about 1,100 rows below the 120 the CI job reads and no practical `--limit` reached it. It is now sorted by most-recently-updated, which puts a close from a minute ago on page 1. 3. **Silent findings name the file.** `loadCatalog()` returns spec objects without the path that produced them, so every live silent finding printed `-> null` — a report nobody can act on. The walk is repeated locally for that one field. ## Evidence, live, `--limit 60 --max-age-days 2` Before: no blocked count, and every finding ended `-> null`. After: ``` closed while still blocked : 2 #742 [Device]: Huawei OceanProtect E8000 Backup S -> no spec exists #743 [Device]: Huawei OceanProtect X8100/X9100 Ba -> no spec exists #804 [Device]: OptiXtrans E6608T -> devices/huawei/optixtrans-e6608t.json #760 [Device]: FS NC8200-4TD -> devices/fs/nc8200-4td.json ``` ## Tests and gates - `test/closed-issues-audit.test.js`: **31 passed, 0 failed** (17 before; the new cases pin the two incident issues against the live mirror file, the `blocked`-before-catalogue precedence, an unparsable/misshapen mirror, the sort parameter, and the path the loader drops). - `node scripts/syntax-check.js`: 394 files, all OK. `npm run check:bytes`: clean. - `test/request-queue.test.js` 23 passed, `test/skip-audit.test.js` 15 passed — the other suites that touch this script. - Full `node scripts/run-tests.js` is running on the branch; this PR touches one standalone script and the docs, not engine code. ## Docs `docs/RESOLUTIONS.md` described three counts and now describes four, with the mechanism and the ordering reason. `CONTRIBUTING.md` gains "What a pull request body closes": write `Refs #N`, keep the number away from those nine words everywhere else in the body, including headings and quoted comments.
closed-issue audit: report a close that contradicts the blocked-request record
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Test (Node 20) (pull_request) Successful in 46s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 50s
CI / Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 10s
bbcf30c77b
#742 and #743 closed themselves on 2026-11-17, seconds after their own last
comment said the issue stays open. Nothing was built. Forgejo reads a close
keyword followed by an issue number anywhere in a pull request body, so PR
#1867's disclaimer and PR #1873's 'what would close' heading were both
executed as instructions to close.

The catalogue cannot catch that - there is no device to match - so the audit
now reads research/open-device-requests.json, this project's own record of the
requests the vendor will not let us model, and reports any close there as a
finding ('blocked'). --strict fails on it, the JSON output carries it, and a
mirror that will not parse is printed rather than silently disabling the check.

Two more gaps found by running it against the live tracker:

- The list was fetched in the instance's default order, by issue number, so a
  close on an old-numbered request sat ~1,100 rows below the 120 the CI job
  reads. It is now sorted by most recent update, which puts a fresh close on
  page one.
- loadCatalog() drops the path, so every silent finding printed '-> null'.
  The walk is repeated locally for that one field; all nine live findings now
  name their spec.

The two requests are reopened with the mechanism documented, and CONTRIBUTING
says to write 'Refs #N' and keep the number away from those keywords.
jaylouisw force-pushed fix/1117-2105 from bbcf30c77b
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Test (Node 20) (pull_request) Successful in 46s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 50s
CI / Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 10s
to e90b4b0692
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 27s
CI / Test (Node 20) (pull_request) Failing after 56s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 1m0s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 21:33:52 +00:00
Compare
jaylouisw force-pushed fix/1117-2105 from e90b4b0692
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 27s
CI / Test (Node 20) (pull_request) Failing after 56s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 1m0s
CI / Arm auto-merge (pull_request) Successful in 4s
to 5289472da6
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Successful in 49s
CI / Test (Node 22) (pull_request) Successful in 52s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Arm auto-merge (pull_request) Successful in 9s
2026-11-17 21:58:20 +00:00
Compare
jaylouisw force-pushed fix/1117-2105 from 5289472da6
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Successful in 49s
CI / Test (Node 22) (pull_request) Successful in 52s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Arm auto-merge (pull_request) Successful in 9s
to 3b4bc0ffea
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Classify the change (pull_request) Successful in 12s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 20) (pull_request) Successful in 49s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 53s
CI / Docker build (pull_request) Successful in 19s
CI / Arm auto-merge (pull_request) Successful in 20s
2026-11-17 21:59:58 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1901
No description provided.