ci: bound every network fetch, and answer the classify job instead of hanging #1856
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1856
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1117-1420"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was slow/broken
Classify the changeis the gate on all five other jobs, and itstimeout-minutes: 5is not enforced by this runner. From/actions/tasks, classify tasks that held a slot and then failed silently (no log written at all, so no step ever returned):For the whole of each, the PR's five jobs read Blocked by required conditions (commit status for
1f647259on #1851:CI / Classify the change failure - Failing after 13m48s, everything elsepending - Blocked by required conditions). Duration isrun_started_at -> updated_at, so this is execution, not queueing;jobs/*/logsreturnsfile does not existfor every one of them.Change (workflow only)
git fetchinchanges,test,smoke,dockeris nowtimeout N+-c http.lowSpeedLimit=1000 -c http.lowSpeedTime=30(120 s classify, 60 s base, 300 s legs) - the same pair that fixed the stuck fetch in the demo deploy script;classify-change.jsgives for an unreadable base -data_only=false,code=true- and the five jobs run;Coverage unchanged
data_only=true(the only output that lets smoke and Docker stand down) is never written on a fallback path, andliveis untouched. Fallbacks only ever add jobs, never remove one.Measured
Blocked by required conditions).a5e90d17over3866046d, run 5259 answereddata_only=true / code=false / changed files (1): data docs/CLI.md; the new step body answers byte-identically (checked out against odin in a scratch clone), and a dead server answersdata_only=false / code=trueand exits 0 in ~2 s.run:blocks passbash -n;check-ci-disk-hygiene,check-node-surface,check-canonical-urlspass.5abd3a286161dca67c5f