docs(CI): a data-only diff still runs all three Node legs #1704
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1704
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1116-1815"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
docs/CI.mdsaid a data-only pull request runs the test job on Node 20 only, sonpm testwas checked "once instead of three times".The workflow says otherwise, twice:
testjob is guarded only byneeds.changes.outputs.live != 'false', and its strategy ismatrix: node: [18, 20, 22]for every open pull request � there is nodata_onlyterm in it;data_onlyis read in exactly two places: theif:of thesmokejob (line 366) and of thedockerjob (line 394).The workflow comment above the matrix records why the reduction was removed: an
if:readingmatrix.nodeis evaluated before the matrix exists, so every leg died ~2 s in (runs 1398, 1401, 1402 � three red Xs per pull request), and a matrix built from an expression collapses to a single unnamed leg that runs the suite once and reports coverage it never had. "So: three versions, always."Changed (docs only): the table now reads
Test (Node 18/20/22)? three legs for both kinds of diff, with a line saying only the last two columns differ; the paragraph explains what the data-only saving actually buys (two ten-minute jobs,smokeanddocker, against ~60 s for the suite); and the "five checks, all required before a merge" sentence gains the qualification the page was already contradicting three screens later.Guards, before = after: syntax-check 356 files OK, control-bytes clean, doc-catalog-counts 43/43, doc-citations 11/11, docs-show-commands 7/7 (51 forms / 102 commands / 60 refusals), help-completeness 8/8, no-form-help-key 81/81.
229e3b924418f3511f30