plan: the request queue's duplicate test cannot see a slug-named model (#795) #1703

Merged
jaylouisw merged 1 commit from plan/1116-1810 into main 2026-11-16 18:15:58 +00:00
Owner

Forward plan only, no code. docs/plans/request-queue-duplicates.md.

Two scripts answer "is this request already modelled?" and they disagree. scripts/request-queue.js:68,109 compares vendor|model verbatim; scripts/sweep-device-requests.js:110 normalises (entities, dashes, punctuation) and has nine guard-documented cases behind it in test/sweep-requests.test.js.

Measured on 9438e075 against the live tracker (20 open device-request issues, 2,257 catalogue specs of which 1,682 are slugs):

  • queue predicate: 0 duplicates, 20 "ready to implement"
  • sweep normaliser: 1 duplicate — #795 NetEngine 8000 M4 -> devices/huawei/netengine-8000-m4.json

So the queue offers hardware that is already in the catalogue as the next device to write. The predicate also has no test and no seam (:193 parseIssue: null), and neither script runs anywhere — closed-audit.yml is the only workflow that runs an issue script.

Six ordered steps, each one PR: (1) extract one matcher module and re-export from the sweeper so its suite is untouched, (2) the queue asks it, with #795 as the regression fixture, (3) negatives that protect the guards (UDW-PRO vs UDW, NC8400-4TH vs nc8200-4td), (4) the sweeper takes its API base from the probe check-closed-issues.js:109-140 already uses, (5) a report-only workflow on merge in the closed-audit.yml shape, (6) the close pass — tracker action, needs Jay.

Left out deliberately: automatic closing, the 19 device specs themselves, a second fuzzy tier, and #1507 (host work).

Forward plan only, no code. `docs/plans/request-queue-duplicates.md`. Two scripts answer "is this request already modelled?" and they disagree. `scripts/request-queue.js:68,109` compares `vendor|model` verbatim; `scripts/sweep-device-requests.js:110` normalises (entities, dashes, punctuation) and has nine guard-documented cases behind it in `test/sweep-requests.test.js`. Measured on `9438e075` against the live tracker (20 open `device-request` issues, 2,257 catalogue specs of which 1,682 are slugs): - queue predicate: 0 duplicates, 20 "ready to implement" - sweep normaliser: 1 duplicate — #795 NetEngine 8000 M4 -> `devices/huawei/netengine-8000-m4.json` So the queue offers hardware that is already in the catalogue as the next device to write. The predicate also has no test and no seam (`:193` `parseIssue: null`), and neither script runs anywhere — `closed-audit.yml` is the only workflow that runs an issue script. Six ordered steps, each one PR: (1) extract one matcher module and re-export from the sweeper so its suite is untouched, (2) the queue asks it, with #795 as the regression fixture, (3) negatives that protect the guards (`UDW-PRO` vs `UDW`, `NC8400-4TH` vs `nc8200-4td`), (4) the sweeper takes its API base from the probe `check-closed-issues.js:109-140` already uses, (5) a report-only workflow on merge in the `closed-audit.yml` shape, (6) the close pass — tracker action, needs Jay. Left out deliberately: automatic closing, the 19 device specs themselves, a second fuzzy tier, and #1507 (host work).
plan: the request queue's duplicate test cannot see a slug-named model, so #795 reads as ready (#795)
All checks were successful
CI / Classify the change (pull_request) Successful in 13s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 13s
CI / Server smoke test (pull_request) Successful in 19s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 20) (pull_request) Successful in 59s
CI / Test (Node 18) (pull_request) Successful in 1m5s
CI / Test (Node 22) (pull_request) Successful in 1m4s
fb18d67a23
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 18:15:48 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1703
No description provided.