A stated range is the range the check applies (#1505) #1549
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1549
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1115-2105"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1505
What was wrong
channel-group 4097 mode activewas accepted and built a bundle, while the refusal in the same handler says a channel group is1-4096. The condition was a digits check plusNumber(id) < 1— a lower bound only, left behind by #1495.show etherchannel summarythen printed the impossible bundle as fact.spanning-tree priority 61441was answered by the multiple-of-4096 rule (the range was tested last), which computed its neighbours arithmetically and offered "the nearest valid values are 61440 and 65536". 65536 is refused by the same handler, so the correction led straight into a second refusal.What changed
engine/cli.js: the channel-group id check applies both ends of the range it prints; a refused id leaves no entry inconfig.lags, no membership on the port and no row inshow etherchannel summary.engine/cli.js: the bridge-priority range is checked before the step rule, in the words the neighbouring refusals already use (the range is 0 to 61440), so no suggestion can fall outside the range.test/stated-range-is-the-enforced-range.test.js: eight settings probed at four points (below, low edge, high edge, above) must go refused / accepted / accepted / refused; both refusals must state the range; and any value a refusal offers as valid is probed too.docs/CLI.mdsection A stated range is the range the check applies.Verification
test/stated-range-is-the-enforced-range.test.js50 passed / 0 failed; with the previous handlers 45 passed / 5 failed, the five being 4097 accepted, its bundle table entry, its summary row, and the two 61441 message checks.node scripts/syntax-check.js325 files;stp-priority41/41;command-answers-the-question27/27;lag57/57;help-completeness8/8;check-doc-citationsexit 0.Measured and left alone
vlan,vrrp(id and priority),ipv6 nd ra lifetime,ip ospf costandping <count>already enforce both ends of the range they print, and the test keeps them that way. The other link-aggregation defects in #1510 (ano channel-group <id>that acts on another group, a port joining several bundles) are untouched here and remain open.10798b3480f3e9118cc1Rebased onto
00204b30(was 3 behind). One conflict,engine/cli.js: main's #1543 introduced_channelGroupId(), and it already applies both bounds -Number(s) < 1 || Number(s) > 4096- so the inline check this PR adds was a duplicate of the fix, not a competitor. Kept main's_channelGroupIdcall and dropped the duplicated block, leaving a comment that names #1505 and says where the ceiling now lives. The spanning-tree-priority half of the PR is untouched and is the part main does not have.Head
10798b34?f3e9118c. Verified: syntax 325 OK,stated-range-is-the-enforced-range50/50,lag57/57,stp64/64,cli8/8.This branch conflicts with
main, so it was not rebased:A conflict is a decision about behaviour rather than a mechanical fix, so this is left for a human. Rebasing by hand and force-pushing will let the automation pick it up again.
f3e9118cc17804e43448The rebase workflow reported a conflict on this branch at 22:06 naming
docs/CLI.md engine/cli.js test/stated-range-is-the-enforced-range.test.js. That report was stale: rebased by hand just now and there was no conflict at all.git worktree add --detach pr-1549 origin/fix/1115-2105->git rebase origin/main-> "Successfully rebased and updated detached HEAD", first try, nothing to resolve.f3e9118cwas already the resolved result of theengine/cli.jsdecision recorded above at 21:25, so there was nothing left for the bot to collide with; the diff against main is unchanged (3 files, +240/-4).Head
f3e9118c?7804e434(base00204b30?2ce2d029, was 4 behind).Verified after the rebase:
npm testfull run - 256 suites, 9,347 assertions, 0 failed (including the port-type audit and the control-bytes check). Targeted:stated-range-is-the-enforced-range50/50,cli8/8,stp64/64.Content is the spanning-tree-priority half of #1505, unchanged: the range is asked before the multiple-of-4096 rule, so
spanning-tree priority 61441no longer answers with a suggestion of 65536;channel-groupkeeps using_channelGroupId()so the printed range and the checked range cannot drift.7804e434481774306d71jaylouisw referenced this pull request2026-11-16 09:25:27 +00:00
jaylouisw referenced this pull request2026-11-17 01:41:33 +00:00
jaylouisw referenced this pull request2026-11-17 07:31:44 +00:00
jaylouisw referenced this pull request2026-11-17 12:06:27 +00:00