A no channel-group undoes the group it names, and a port belongs to one bundle (#1510) #1543
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1543
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1115-2035"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1510
no channel-group <id>threw the id away: the dispatcher called_channelGroup(['remove'], iface), sono channel-group 9999answeredFa0/1 removed from channel group 2 (the group had no other members)and theport left the bundle that was carrying traffic.
What changed in
engine/cli.js:no channel-group <id>validates it (1-4096, both ends - the shared_channelGroupId()is now used by the set form too, which tested only the lower bound while its refusalstated the whole range) and removes the port from that group. An id that is not the port's group is a
refusal naming both groups:
% Fa0/1 is not in channel group 5: it is in group 2. A bareno channel-groupkeeps its old meaning - whatever the port is in.channel-groupmoves it, and saysInterface Fa0/1 moved from channel group 2 to 10 (mode on); the group it left is deleted if it is nowempty.
show etherchannel summaryorders bundles by number (2, 10, 100), not as strings (10, 100, 2).docs/CLI.mdgains a short section next to the etherchannel table.Tests:
test/no-command-touches-only-what-it-names.test.js- 4 new checks, 11/11 in the file; three of themfail against the previous handler (the wrong-group
no, the move, the order). Full suite 253 suites / 9243assertions / 0 failed; syntax-check 323 files;
lag-mode50/50,lag-member-checks8/8,lag-member-down30/30,l228/28.Not done here: #1505's own test (
stated-range-is-the-enforced-range.test.js) - the ceiling it asks for fallsout of the shared check, but the four-point probe table is left to that issue.
no channel-groupundoes the group it names, and a port belongs to one bundle (#1510)24ae336719b62ed97347