Sweeper: report requests a family member already answers, and stop calling an accessory a device #1203
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1203
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/sweeper-hints"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1202. Two failures from one code path, in opposite directions.
It hid requests that were already done. #6 "Microsoft Xbox" and #7 "Amazon Fire TV Stick" sat open while
devices/microsoft/xbox-series-x.jsonandfire-tv-stick-4k-max-2nd-gen.jsonwere in the catalogue, because the sweep only accepts an exact normalised model name. That exactness is right - closing someone's request by pointing at a different product is the mistake this script exists to avoid - but the tool therefore reported "nothing to do" over a backlog with answers in it.A hint tier now reports what it cannot close: request words that are a prefix of a same-vendor model name the candidate and its file, and
--closenever reads that list.Microsoft Xbox->microsoft/Xbox Series X;Amazon Fire TV Stick->amazon/Fire TV Stick 4K Max (2nd gen).It closed an accessory as a device. #246 "Iso-Beam-19 RF Isolator Shield for NanoBeam NBE-M2-13, NBE-M5-19" matched
NBE-M5-19, the radio the shield clips onto. The guard is positional, not a word list: if the matched model is named after an accessory preposition (for,compatible with,fits,works with,mounts on), the request is about something that fits it - reported, never closed. A model named before the preposition, and a title that never names the model, both stay non-accessories: a guard that fires on uncertainty would silence real requests.What made this findable: a dry run over 138 open requests reported one match, and it was wrong. It now reports one accessory reading and two family hints - and the auto-closeable count is honestly zero. 94 checks in the sweeper's suite, including both real catalogue cases. Full suite: 114 suites, 5,356 assertions.