[Bug]: the device-request sweeper cannot see requests that a family member already covers #1202

Closed
opened 2026-11-09 12:57:36 +00:00 by jaylouisw · 1 comment
Owner

What happens

scripts/sweep-device-requests.js only matches a request when the name in the title resolves to an exact normalised model name (plus part-number and vendor guards). That exactness is deliberate and correct - closing somebody's request by pointing at a different product is worse than leaving it open.

The consequence is that a request covered by a family member is invisible. Two examples that have been open for months and are plainly satisfied:

request what the catalogue actually holds
#843 [Device]: Microsoft Xbox devices/microsoft/xbox-series-x.json - eth0 1G + wlan0, Wi-Fi 5
#842 [Device]: Amazon Fire TV Stick devices/amazon/fire-tv-stick-4k-max-2nd-gen.json and fire-tv-cube-3rd-gen.json

Both were imported in #78 and #111. A dry run today reports 1 match out of 139 open issues, and that single match is a false positive (#246, "Iso-Beam-19 RF Isolator Shield for NBE-M5-19" matching the radio it fits). So the tool is currently near-useless in both directions: it misses the obvious staleness and flags an accessory as the device.

Why it matters

The sweeper is the only automated way this backlog shrinks. If it cannot see the obvious cases, the backlog grows monotonically and every request needs a human to read it - which is exactly what happened here.

What it should do (not what it does now)

Add a hint tier that is reported and never auto-closed: when the request's subject is a proper prefix of a catalogue model from the same vendor (or that model's prefix), list it as "possibly covered" with the candidate's file path and let a human confirm. Microsoft Xbox -> microsoft/Xbox Series X; Amazon Fire TV Stick -> amazon/Fire TV Stick 4K Max (2nd gen). No closing, no comment on the issue: just stop hiding the answer.

The false positive is the same code path from the other side and needs its own guard: a title whose subject is an accessory for a device ("... for NBE-M5-19", "... compatible with X") must not resolve to the device it attaches to.

Reproduce

FORGEJO_TOKEN=<token> node scripts/sweep-device-requests.js
# open issues scanned      : 139
# already in the catalogue : 1        <- #246, and it is wrong

Reported by the autonomous development loop while closing #842 and #843 by hand.

**What happens** `scripts/sweep-device-requests.js` only matches a request when the name in the title resolves to an **exact** normalised model name (plus part-number and vendor guards). That exactness is deliberate and correct - closing somebody's request by pointing at a different product is worse than leaving it open. The consequence is that a request covered by a **family member** is invisible. Two examples that have been open for months and are plainly satisfied: | request | what the catalogue actually holds | |---|---| | #843 `[Device]: Microsoft Xbox` | `devices/microsoft/xbox-series-x.json` - eth0 1G + wlan0, Wi-Fi 5 | | #842 `[Device]: Amazon Fire TV Stick` | `devices/amazon/fire-tv-stick-4k-max-2nd-gen.json` **and** `fire-tv-cube-3rd-gen.json` | Both were imported in #78 and #111. A dry run today reports **1 match out of 139 open issues**, and that single match is a false positive (#246, "Iso-Beam-19 RF Isolator Shield **for NBE-M5-19**" matching the radio it fits). So the tool is currently near-useless in both directions: it misses the obvious staleness and flags an accessory as the device. **Why it matters** The sweeper is the only automated way this backlog shrinks. If it cannot see the obvious cases, the backlog grows monotonically and every request needs a human to read it - which is exactly what happened here. **What it should do (not what it does now)** Add a *hint* tier that is reported and never auto-closed: when the request's subject is a proper prefix of a catalogue model from the same vendor (or that model's prefix), list it as "possibly covered" with the candidate's file path and let a human confirm. `Microsoft Xbox` -> `microsoft/Xbox Series X`; `Amazon Fire TV Stick` -> `amazon/Fire TV Stick 4K Max (2nd gen)`. No closing, no comment on the issue: just stop hiding the answer. The false positive is the same code path from the other side and needs its own guard: a title whose subject is an **accessory for** a device ("... for NBE-M5-19", "... compatible with X") must not resolve to the device it attaches to. **Reproduce** ```bash FORGEJO_TOKEN=<token> node scripts/sweep-device-requests.js # open issues scanned : 139 # already in the catalogue : 1 <- #246, and it is wrong ``` **Reported by** the autonomous development loop while closing #842 and #843 by hand.
Author
Owner

Fixed in #1203, which merged. The report now has a second section that answers the question the sweep could not: possibly covered, needs a human, naming the candidate's file for each. Nothing in that section is ever closed by --close.

The three cases from this issue, against the live backlog of 138:

possibly covered, needs a human : 3
  #246   Ubiquiti Iso-Beam-19 RF Isolator Shield  -> reads as an accessory for ubiquiti NBE-M5-19
  #7     Amazon Fire TV Stick                     -> amazon/Fire TV Stick 4K Max (2nd Gen)
  #6     Microsoft Xbox                           -> microsoft/Xbox Series X

#6 and #7 were then closed for real (the devices are in the catalogue); #246 stays open because it is a shield, not a radio. The accessory guard is positional - a model named after for/compatible with/fits is a target, not the subject - so it does not fire on a model named first, and it does not fire on a title that never names the model at all.

Fixed in #1203, which merged. The report now has a second section that answers the question the sweep could not: **possibly covered, needs a human**, naming the candidate's file for each. Nothing in that section is ever closed by `--close`. The three cases from this issue, against the live backlog of 138: ``` possibly covered, needs a human : 3 #246 Ubiquiti Iso-Beam-19 RF Isolator Shield -> reads as an accessory for ubiquiti NBE-M5-19 #7 Amazon Fire TV Stick -> amazon/Fire TV Stick 4K Max (2nd Gen) #6 Microsoft Xbox -> microsoft/Xbox Series X ``` #6 and #7 were then closed for real (the devices are in the catalogue); #246 stays open because it is a shield, not a radio. The accessory guard is positional - a model named after `for`/`compatible with`/`fits` is a target, not the subject - so it does not fire on a model named first, and it does not fire on a title that never names the model at all.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge#1202
No description provided.