[Bug]: the device-request sweeper cannot see requests that a family member already covers #1202
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1202
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
scripts/sweep-device-requests.jsonly matches a request when the name in the title resolves to an exact normalised model name (plus part-number and vendor guards). That exactness is deliberate and correct - closing somebody's request by pointing at a different product is worse than leaving it open.The consequence is that a request covered by a family member is invisible. Two examples that have been open for months and are plainly satisfied:
[Device]: Microsoft Xboxdevices/microsoft/xbox-series-x.json- eth0 1G + wlan0, Wi-Fi 5[Device]: Amazon Fire TV Stickdevices/amazon/fire-tv-stick-4k-max-2nd-gen.jsonandfire-tv-cube-3rd-gen.jsonBoth were imported in #78 and #111. A dry run today reports 1 match out of 139 open issues, and that single match is a false positive (#246, "Iso-Beam-19 RF Isolator Shield for NBE-M5-19" matching the radio it fits). So the tool is currently near-useless in both directions: it misses the obvious staleness and flags an accessory as the device.
Why it matters
The sweeper is the only automated way this backlog shrinks. If it cannot see the obvious cases, the backlog grows monotonically and every request needs a human to read it - which is exactly what happened here.
What it should do (not what it does now)
Add a hint tier that is reported and never auto-closed: when the request's subject is a proper prefix of a catalogue model from the same vendor (or that model's prefix), list it as "possibly covered" with the candidate's file path and let a human confirm.
Microsoft Xbox->microsoft/Xbox Series X;Amazon Fire TV Stick->amazon/Fire TV Stick 4K Max (2nd gen). No closing, no comment on the issue: just stop hiding the answer.The false positive is the same code path from the other side and needs its own guard: a title whose subject is an accessory for a device ("... for NBE-M5-19", "... compatible with X") must not resolve to the device it attaches to.
Reproduce
Reported by the autonomous development loop while closing #842 and #843 by hand.
Fixed in #1203, which merged. The report now has a second section that answers the question the sweep could not: possibly covered, needs a human, naming the candidate's file for each. Nothing in that section is ever closed by
--close.The three cases from this issue, against the live backlog of 138:
#6 and #7 were then closed for real (the devices are in the catalogue); #246 stays open because it is a shield, not a radio. The accessory guard is positional - a model named after
for/compatible with/fitsis a target, not the subject - so it does not fire on a model named first, and it does not fire on a title that never names the model at all.