ci: drop GitHub-legacy workflows (CodeQL + GitHub ci.yml fail on Forgejo) #1059
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1059
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/remove-github-workflows"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forgejo 11 reads .github/workflows/ in addition to .forgejo/workflows/, so the GitHub-legacy files were running and failing:
Removes the whole .github/workflows/ tree. CI now lives solely in .forgejo/workflows/ci.yml (and the new auto-rebase.yml).
Why this PR is the fix for the red
Docker buildcheckVerified from the runner log of run 173 (PR #915, job index 4,
Docker build):The runner image is
node:20-bookworm, which has nodockerbinary. The legacy.github/workflows/ci.ymldocker job runs a baredocker build, so it fails withexit 127 on every pull request whose head still predates
.forgejo/workflows/ci.yml.Two things made this worse than a single red check:
if: github.server_url == 'https://github.com'guard on the legacy jobs doesnot skip them on Forgejo — the jobs execute and fail.
indistinguishable from a real regression in the queue.
Scale of the problem across open PRs (from the actions task history):
Docker build89 failures / 3 successes,
Analyze(CodeQL) 78/78 failures.Server smoke test92/92 green,
Test~73/93 per Node version.Deleting
.github/workflows/leaves.forgejo/workflows/ci.yml, whose docker jobprobes
command -v dockerfirst and reports "no daemon" instead of failing. That isthe behaviour the queue needs.
Landing this also stops the queue growing with jobs that can never pass on this host.