ci(auto-rebase): a superseded pass leaves a red status on main - keep both passes #2450

Merged
jaylouisw merged 1 commit from ci/1121-1646 into main 2026-11-21 17:08:11 +00:00
Owner

What was broken. auto-rebase.yml declares no concurrency block, so Forgejo cancels every superseded run of it on a push (Actions reference, v15: "any other invocations of the same workflow will be canceled automatically"). That cancellation is written to the commit as a failure status, and the workflow fires on every push to main.

Evidence.

  • 94 of 413 auto-rebase runs in the 51 h to 2026-11-21T16:30Z are cancelled (23%); 18 of 41 push-triggered ones in the 13 h to then (44%).
  • Run 8178 (push, 9a70a2fb, 2026-11-20T03:08:04Z) was cancelled 19 s in and left Auto-rebase / Rebase open PRs and arm auto-merge (push) = failure on main's head; main-health quoted exactly that status in the "main is red" issue #2325 at 22:35Z, beside a real Node 18 failure - a green merge reported as a red main.
  • Run 9557 (2026-11-21T16:37:41Z) is the same shape: cancelled at 16:37:56, failure on 726c65f9.

Change. concurrency: cancel-in-progress: false, no group - the documented way to switch the implicit cancellation off; with no group nothing can queue or deadlock (the reason this file has no group).

Measured before/after (same instance, same day, probe workflow with the same push trigger and a 30 s job): without the block, 9553 was cancelled 14 s in when 9554 was pushed; with it, 9555 and 9556 both ran to success (31 s each, overlapping). This file takes effect on the next push to main; the metric is auto-rebase push runs cancelled (18/41) vs success.

Coverage unchanged. No step, check, bound or branch is touched; the pass runs exactly as before, only not killed half-way, and main's head no longer carries a red status for a pass that was never allowed to run.

**What was broken.** `auto-rebase.yml` declares no `concurrency` block, so Forgejo cancels every superseded run of it on a push (Actions reference, v15: "any other invocations of the same workflow will be canceled automatically"). That cancellation is written to the commit as a **failure** status, and the workflow fires on every push to main. **Evidence.** - 94 of 413 `auto-rebase` runs in the 51 h to 2026-11-21T16:30Z are `cancelled` (23%); 18 of 41 push-triggered ones in the 13 h to then (44%). - Run **8178** (push, `9a70a2fb`, 2026-11-20T03:08:04Z) was cancelled 19 s in and left `Auto-rebase / Rebase open PRs and arm auto-merge (push) = failure` on main's head; `main-health` quoted exactly that status in the "main is red" issue **#2325** at 22:35Z, beside a real Node 18 failure - a green merge reported as a red main. - Run **9557** (2026-11-21T16:37:41Z) is the same shape: cancelled at 16:37:56, `failure` on `726c65f9`. **Change.** `concurrency: cancel-in-progress: false`, no `group` - the documented way to switch the implicit cancellation off; with no group nothing can queue or deadlock (the reason this file has no group). **Measured before/after** (same instance, same day, probe workflow with the same push trigger and a 30 s job): without the block, **9553** was cancelled 14 s in when **9554** was pushed; with it, **9555** and **9556** both ran to success (31 s each, overlapping). This file takes effect on the next push to main; the metric is `auto-rebase` push runs `cancelled` (18/41) vs `success`. **Coverage unchanged.** No step, check, bound or branch is touched; the pass runs exactly as before, only not killed half-way, and main's head no longer carries a red status for a pass that was never allowed to run.
ci(auto-rebase): a superseded pass is cancelled with a red status on main - keep both passes
All checks were successful
CI / Server smoke and Docker build (pull_request) Successful in 29s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Test (Node 20) (pull_request) Successful in 1m9s
CI / Test (Node 22) (pull_request) Successful in 1m10s
CI / Test (Node 18) (pull_request) Successful in 1m11s
CI / Arm auto-merge (pull_request) Successful in 2s
5dd4359ede
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-21 16:48:21 +00:00
forgejo-actions canceled auto merging this pull request when all checks succeed 2026-11-21 17:00:16 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2450
No description provided.