docs(cli): the default-gateway gate is cited inside the OSPF loop #2432
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2432
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1121-1417"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was untrue
docs/CLI.md(theip default-gateway/S* 0.0.0.0/0section, ~line 3558) said the typedconfig.defaultGatewayis consulted only whenisL3()is false, and citedengine/device.js:1139for that gate.Evidence from the code
engine/device.js:1161is the gate:if (!best && this.config.defaultGateway && !this.isL3()).engine/device.js:1435repeats the same test where the route table builds theS*row.engine/device.js:755definesisL3(); line 1139 is inside the OSPF-learned-routes loop (for (const r of (this.ospfRoutes || []))), which is not about the default gateway at all.ip default-gateway 10.0.0.254thenshow ip routeprintsGateway of last resort is not setand noS*row.Fix
Citation corrected to
:1161, with the sibling at:1435named. Wording unchanged; one paragraph rewrapped.Guards (before / after)
scripts/check-doc-citations.js: 380 citations, 3 suspects -> 2 suspects (the two remaining aredocs/BGP-POLICY.md:77/:827namingcli.js:8114for_help()at 8161, left for another run)node scripts/syntax-check.js: 535 files, all OK (before and after)Not done
No code change: the code is right and the doc was wrong. The two
BGP-POLICY.mdcitation suspects are untouched (one item per run).