UPSTREAM-DESIGN: the data path does read Link.state, and has since #1058 #1922
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1922
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1118-0146"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
One claim in
docs/UPSTREAM-DESIGN.md�1.1 is contradicted by the engine.The doc said (measured at
d399dff): marking a WAN linkdowngives an identical trace, because "the data path never readsLink.state", and_deliver()checks onlyiface.enabledandiface.peer;web/app.js"prints a State field in the link inspector that the engine ignores".The code says (
engine/simulator.js:3174,_deliver()):Reproduced: two hosts through a switch pair, addressed,
pingsucceeds;sim.linkDown(mid)and the samepingfails with drop events whose reason islink down(this is whattest/link-state.test.jspinning 69 assertions is about).web/app.jsreadslink.stateat:2347(inspector State row) and:2792(canvas colours a down cable).?? The defect �1.1 is about survives —
routeTo()(engine/device.js:971) still returns one route and nothing asks for a second, so a dead primary is still a dead end. Only the reason changes: the walk stops at the cable with a visible drop instead of passing through it. The row and the paragraph now say that, and work-order row 26 (simulator.js:1595 _deliver(), "emitlink-down") is marked done with the note that the reason rides on adropevent rather than alink-downevent type of its own.Also refreshed two adjacent �1.2 anchors (
derivePortHardware894→941,inferCage786→828) —scripts/check-doc-citations.jsgoes from 3 suspects to 0.Docs-only. Guards: syntax-check 401 files OK; docs-cli-transcript 4/4; docs-show-commands 7/7 (55 forms, 110 commands, 68 device refusals); help-completeness 8/8 (102 advertised commands); help-key-is-not-a-value 40/40; no-form-help-key 81/81; doc-catalog-counts 43/43; check-control-bytes clean; check-canonical-urls 3092 files OK.
a716412d78d4603d69a1