test(ping-default-count): read every Sending N, against the command above it #1850
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1850
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1117-1305"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1845.
The guard added for #1712 was a bare substring test on
docs/CLI.md-Sending 4,may appear nowhere - so it also rejected a transcript that types the count on purpose:That is the example #1840 adds, in the section whose point is the explicit count. The guard now keeps its meaning - no example shows four as the default - by reading each
Sending N,line against the command echoed above it: the command must type N, or type no count and send the documented default of five. A header disagreeing with the typed count is still rejected, so the guard is not vacuous, and a fragment with no command above it may only show the default.Seven fixtures pin the rule itself (bare five accepted, bare four rejected, typed four accepted across the console filler line, typed five with
ataccepted, mismatch rejected, fragments both ways), and the doc assertion now reports the offending lines instead of a bare boolean.Verified against both trees: 25 passed on
main, 25 passed with #1840'sdocs/CLI.mdsubstituted in, so #1840 stops being blocked by this file.Gates
node scripts/syntax-check.js: 387 files, all OK--concurrency=6- canonical-urls, board-id-is-a-name - pass serially and are concurrency artifacts, unrelated to this change)Sending N,against the command above it (#1845)4f153603ff560412df50