forge(docs): locate the LFS store from the host, not at a container path (#1507) #1784
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1784
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1117-0335"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs #1507 - repo side only. This issue stays open: the storage decision itself still needs a shell on the host.
What was wrong
The last step of the disk-full page printed:
and called it "on the host".
/dataonly exists inside the container - the same page records the bind/mnt/user/appdata/forgejo/data -> /datain "Diagnosing which path the database is actually on". On ahost shell the command matches nothing, exits 0, and
2>/dev/nullhides the miss. A reader follows thepage and sees no output, which reads exactly like "there is no LFS here" - the same empty-result-read-as-
measurement error the section above it was written to correct.
What changed
absent: <path>rather than nothing;absentmeans:docker inspect forgejofor the bind, and the[lfs]section of
app.iniforPATHandSTORAGE_TYPE;STORAGE_TYPEother thanlocalis called out explicitly: the GiBs are then not on this volume at all,so
df -hhere can never see them and deleting LFS objects is not the repair.Tests
test/forge-space-accounting.test.js: 20 assertions, 5 of them new and all 5 red on the previous page.Full suite: 302 suites, 10,583 assertions, 0 failed.
node scripts/syntax-check.js: 373 files, all OK.The printed commands were run in this session (the loop prints
absent:for missing paths; thesedrange exits 0 on a file with no
[lfs]block).a2292e6d61ea18284a53ea18284a5381bd935979