converge at <ms> — the form help prints — answers "converged" instead of refusing #1726
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1726
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The command the console tells you to type does not do what it says
helphas advertisedconverge [at <ms>](engine/cli.js:5272) for as long as the command has existed, and_converge()readNumber(tokens[0])and nothing else. So the advertised form was never refused — it wasanswered as if no instant had been named.
Number('at')isNaN; aNaNinstant fails the per-rowe.readyAtMs > atMstest, so every(pending)markdisappears. On a lab whose OSPF is ready at 16000 ms:
The second answer is
convergewith no instant at all: the lab is reported converged at an instant before itconverges. Nothing fails, nothing warns, and the operator has no way to see that a different question was answered.
The
(pending)column is the entire output of this command, so the whole answer is wrong.The rest of the argument parser drops words too
converge wibbleconverge— the word is ignoredconverge at wibbleconverge atconverge 1000 wibbleconverge 1000— the word is ignoredconverge -5(pending)link <up|down> <id> at <ms>has parsedatsince #1049, andpingrefuses a stray word by name since #1379.convergeis the one lab operation that does neither.Note on the page that already said so
docs/CLI.mdcarried a paragraph admitting the discrepancy and telling the reader to type the bare form, ending"the fix belongs in the parser (take
atthe waylinkdoes); until it lands, this line names the spelling thatworks". This issue is that fix.
Found while walking the open queue; the loop's test asserts the behaviour, so the assertion fails on
mainandpasses with the change in the pull request that closes this.
converge at <ms>answers the question it prints (#1726) #1728