docs(ARCHITECTURE): the ping-ipv6 suite is 44 checks, not 43 #1723

Merged
jaylouisw merged 3 commits from docs/1116-2015 into main 2026-11-16 20:23:09 +00:00
Owner

docs/ARCHITECTURE.md said test/ping-ipv6.test.js pins the IPv6 ping report with 43 checks. The file now prints 44 passed, 0 failed.

Evidence from the code: #1712 (74601040) made a bare ping <address> send five echoes, and as part of that added 4 to the seq list that asserts each timed-out echo is named (for (const seq of ['0','1','2','3','4'])), so the suite grew by exactly one assertion. The same commit updated the transcript in the paragraph above (Sending 5, !!!!!, 5/5) but not the count two lines below it.

Docs-only change, one line: 43 -> 44.

Guards: syntax-check 358 files OK; control-bytes clean; docs-show-commands 51 forms / 102 commands / 60 refusals / 7 passed; help-completeness 8 passed (98 advertised commands, 18 mechanisms, 16 shows); no-form-help-key 81 passed; help-key-works-in-every-prompt 10 passed; node test/ping-ipv6.test.js 44 passed, 0 failed.

Not fixed here (separate items, both verified stale by running the suites): docs/ARCHITECTURE.md also claims 48 checks for test/show-view-phrase.test.js (49) and 18 for test/reason-names-the-box.test.js (19), and check-doc-citations flags three stale line numbers (CLI.md _converge() cite, two in BGP-POLICY.md).

`docs/ARCHITECTURE.md` said `test/ping-ipv6.test.js` pins the IPv6 ping report with **43 checks**. The file now prints **44 passed, 0 failed**. Evidence from the code: #1712 (74601040) made a bare `ping <address>` send five echoes, and as part of that added `4` to the seq list that asserts each timed-out echo is named (`for (const seq of ['0','1','2','3','4'])`), so the suite grew by exactly one assertion. The same commit updated the transcript in the paragraph above (`Sending 5`, `!!!!!`, `5/5`) but not the count two lines below it. Docs-only change, one line: 43 -> 44. Guards: syntax-check 358 files OK; control-bytes clean; docs-show-commands 51 forms / 102 commands / 60 refusals / 7 passed; help-completeness 8 passed (98 advertised commands, 18 mechanisms, 16 `show`s); no-form-help-key 81 passed; help-key-works-in-every-prompt 10 passed; `node test/ping-ipv6.test.js` 44 passed, 0 failed. Not fixed here (separate items, both verified stale by running the suites): `docs/ARCHITECTURE.md` also claims 48 checks for `test/show-view-phrase.test.js` (49) and 18 for `test/reason-names-the-box.test.js` (19), and `check-doc-citations` flags three stale line numbers (CLI.md `_converge()` cite, two in BGP-POLICY.md).
docs(ARCHITECTURE): the ping-ipv6 suite is 44 checks, not 43 (#1712 added the fifth seq)
All checks were successful
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 18s
CI / Test (Node 20) (pull_request) Successful in 51s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Test (Node 22) (pull_request) Successful in 56s
237943ad6a
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 20:23:00 +00:00
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 20:23:03 +00:00
jaylouisw force-pushed docs/1116-2015 from 237943ad6a
All checks were successful
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 18s
CI / Test (Node 20) (pull_request) Successful in 51s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Test (Node 22) (pull_request) Successful in 56s
to 95a42ccdd6
All checks were successful
CI / Classify the change (pull_request) Successful in 13s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Test (Node 18) (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Has been skipped
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
2026-11-16 20:23:05 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1723
No description provided.