test: every server start waits a minute, not twenty seconds (#1720) #1721
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1721
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-2005"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1720.
The 20:05 UTC run of
f4e22080atPF_TEST_CONCURRENCY=10came back 10227 assertions passed, 1 failed, and the failure was a crash, not an assertion:The
|is the child captured output and it is empty, so the restarted server had not reachedlisteninside the 20 s it was given. Same file, same run, next attempt: 26.8 s and 65/65.Changed
test/server-start-deadline.test.js— noDate.now() + <literal>under a minute anywhere intest/, checked against the two real lines (20000 flagged, 60000 not) so the lint cannot quietly stop recognising its own shape.board-id-is-a-name—startServersplit into spawn +waitReady(port, deadline), and #1715 assertion added: a port with nothing behind it fails at the deadline it was given (400 ms), which is the part that was never exercised.Gates:
npm testat 10-way — 288 suites / 10300 assertions / 0 failed (was 287 / 10227 / 1).scripts/syntax-check.js359 files OK.