docs(CLI): the ? key at the end of a no line is refused with the syntax it stopped #1710

Merged
jaylouisw merged 2 commits from docs/1116-1845 into main 2026-11-16 18:53:20 +00:00
Owner

docs/CLI.md said the only mid-line ? the console answers is the one after show ("Every other place is left alone deliberately"). engine/cli.js grew a second table in #1699: NO_FORMS, 32 branches (15 config, 9 interface, 8 DHCP pool), checked by _noHelpKeyRefusal() before any no branch acts. So a ? at the end of a no line is now refused in the words of the branch it stopped, and no ? alone answers with the incomplete-command line.

Measured against the parent handler (ae77996c^): no vlan 42 name ? -> VLAN 42 removed, no hostname ? -> Hostname cleared (device is now d1), no description ? -> Description removed: uplink to core; now each is refused and nothing changes. test/no-form-help-key.test.js: 13 passed / 68 failed on the old handler, 81 / 0 now.

The new subsection documents the refusal, the whole-token rule, the unknown-head answer and the no ? case, with transcripts typed back into a live session.

Guards: syntax-check 356 files OK; docs-show-commands 7/7; help-completeness 8/8; no-form-help-key 81/81; help-key-is-not-a-value 40/40; doc-catalog-counts 43/43; doc-citations 11/11; canonical-urls 52/52; full suite 285 suites / 10255 assertions / 0 failed.

Docs-only.

`docs/CLI.md` said the only mid-line `?` the console answers is the one after `show` ("Every other place is left alone deliberately"). `engine/cli.js` grew a second table in #1699: `NO_FORMS`, 32 branches (15 config, 9 interface, 8 DHCP pool), checked by `_noHelpKeyRefusal()` before any `no` branch acts. So a `?` at the end of a `no` line is now refused in the words of the branch it stopped, and `no ?` alone answers with the incomplete-command line. Measured against the parent handler (`ae77996c^`): `no vlan 42 name ?` -> `VLAN 42 removed`, `no hostname ?` -> `Hostname cleared (device is now d1)`, `no description ?` -> `Description removed: uplink to core`; now each is refused and nothing changes. `test/no-form-help-key.test.js`: 13 passed / 68 failed on the old handler, 81 / 0 now. The new subsection documents the refusal, the whole-token rule, the unknown-head answer and the `no ?` case, with transcripts typed back into a live session. Guards: syntax-check 356 files OK; docs-show-commands 7/7; help-completeness 8/8; no-form-help-key 81/81; help-key-is-not-a-value 40/40; doc-catalog-counts 43/43; doc-citations 11/11; canonical-urls 52/52; full suite 285 suites / 10255 assertions / 0 failed. Docs-only.
docs(CLI): a ? at the end of a no line names the syntax and changes nothing
All checks were successful
CI / Classify the change (pull_request) Successful in 20s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 16s
CI / Test (Node 20) (pull_request) Successful in 54s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Test (Node 22) (pull_request) Successful in 57s
9f7488c816
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 18:53:08 +00:00
jaylouisw force-pushed docs/1116-1845 from 9f7488c816
All checks were successful
CI / Classify the change (pull_request) Successful in 20s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 16s
CI / Test (Node 20) (pull_request) Successful in 54s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Test (Node 22) (pull_request) Successful in 57s
to 9bbeaba73d
All checks were successful
CI / Classify the change (pull_request) Successful in 13s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Test (Node 18) (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Has been skipped
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
2026-11-16 18:53:13 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1710
No description provided.