cli: no vlan refuses a VLAN a port holds as its staged voice VLAN #1705
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1705
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1116-1805"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1701.
switchport voice vlan 20on a port that is not a trunk is stored — the receipt says so — andclassifyEgressonly reads the voice VLAN once the mode is trunk. So nothing in the switch carried VLAN 20 and nothing stoppedno vlan 20: the VLAN went, the port keptswitchport voice vlan 20, and oneswitchport mode trunklater the switch was carrying voice traffic in a VLAN it did not have.The
stagedguard inno vlanalready refuses two kinds of reference on a port that is not a trunk yet — a native VLAN and an allowed list — on the stated ground that removing the VLAN otherwise leaves the port pointing at something that is not there. The voice VLAN (#1368) added a third staged reference and the guard was never extended to it. It is now named with the other two, in the same sentence:The access-VLAN case is untouched: the device deletes the VLAN and the port goes
down (inactive), whichvlan-delete-leaves-port-inactive.test.jspins.Tests
test/vlan-delete-leaves-port-inactive.test.js— a new section: the staged voice VLAN refuses the removal and is named, the VLAN and the port are untouched, andswitchport voice vlan nonelets the removal through. 5 of its assertions failed before the fix.node scripts/syntax-check.js— 356 files, all OK.npm test— 285 suites, 10237 assertions, 0 failed.docs/CLI.mdnames the third staged reference, with the combined refusal transcript (verified by running it).no vlan 20deletes a VLAN that a port is still staged for as its voice VLAN #17016f7ad821882eb7da59f2