plan: the server binds every interface, answers any Origin, and has no test for either (#1527) #1592
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1592
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "plan/1116-0310"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forward plan only, no code. New
docs/plans/server-exposure.md.What it plans, in five one-PR steps:
PF_HOST, default127.0.0.1, logged viaserver.address(); Dockerfile setsPF_HOST=0.0.0.0so the published image keeps working. SOrigin/Hostguard on the WebSocket upgrade (server/index.js:1418,server/ws.js:21), absent Origin allowed,PF_ALLOWED_ORIGINSescape hatch, 403 before the 101. S/Msubscribeit never sent. SSECURITY.md:35-43,ARCHITECTURE.mdandREADME.mdto match. SThe plan deliberately leaves out the bearer token (item 3 of #1527): there is no credential store yet, so it would protect nothing and needs Jay's approval when it lands.
Evidence gathered from main:
server.listen(PORT)with no host,Access-Control-Allow-Origin: *on every JSON answer (the REST read path #1527 does not mention), and two server-spawning tests that only ever poll 127.0.0.1, so a0.0.0.0default is invisible.c6987798577568ef7ba27568ef7ba20eb4065714