vlan, lacp and stp are documented capabilities that no code reads #1526
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1526
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
engine/device.js:98-100documentsvlan,lacpandstpas capabilities ("supports 802.1Q" etc.), but no code branches on any of them - spanning-tree is gated onisL2(engine/cli.js:13429-13431) - and all 1,661 catalogue specs contain zero occurrences of the three tokens.A capability census on 2026-11-11 found the same thing from the data side: 19 distinct capability strings across the specs, only 12 of the engine's 15 tokens used by any spec, and these three set by nothing.
Why it matters:
hasCap('802.3af')-style questions are how callers decide whether to offer a command. Three tokens that answertruefor nobody, and are documented as behaviour, teach every future reader something false.Suggested fix: either wire them to the behaviour they name (and let a device refuse
switchport mode trunkwhen it lacksvlan), or remove them fromCAPABILITIESand from the documentation. Keeping them documented-and-inert is the one option to avoid.